Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Request for GCI #474

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Pull Request for GCI #474

wants to merge 2 commits into from

Conversation

prankorigami
Copy link

GCI Username: Pranav Krishnakumar

@eeshangarg
Copy link
Member

@PranzGD: Your avatars look good! However, there are a few minor problems with your PR!

  1. There should only be one commit in your PR, not two.
  2. The commit message for the first commit needs to end with a period.
  3. You do not need an empty readme.md file, I would recommend deleting that.
  4. You are supposed to name the folder after your GitHub username, not your name with a space in the middle. So move the files to a folder to one named PranzGD and delete the older folder.

Here's how to do all of that with git:

  1. Run git rebase -i HEAD~2.
  2. Replace pick by squash for the second commit. This will squash the second commit into the previous one.
  3. When you get to the next screen, change the commit message to end with a period and then save.
  4. Run git rebase -i HEAD~1.
  5. Replace pick with edit for the one commit.
  6. Delete the readme.md file and move the files to draw-avatars/PranzGD/
  7. Run git add '*'. Use git status to check that you are on the right track.
  8. Run git commit --amend.
  9. Run git rebase --continue.
  10. Run git push origin master --force.

And that should do it! Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants