Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Upgrade Flutter to 3.24.0-1.0.pre.518 #872

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

sm-sayedi
Copy link
Collaborator

@sm-sayedi sm-sayedi commented Aug 8, 2024

And update Flutter's supporting libraries to match.

We haven't had a Flutter upgrade for over a month now; specifically, there is the spacing property available to Column and Row now, which is helpful in #853. So I think it's a good time to have an upgrade!

And update Flutter's supporting libraries to match.
@sm-sayedi sm-sayedi added the integration review Added by maintainers when PR may be ready for integration label Aug 8, 2024
@sm-sayedi sm-sayedi requested a review from gnprice August 8, 2024 20:24
@rajveermalviya
Copy link
Collaborator

Another big highlight this update is — the Impeller renderer replacing Skia renderer finally being enabled by default on Android (on supported devices, it'll still fallback to Skia at runtime where Vulkan is unsupported or doesn't provide the required capabilities).

@gnprice
Copy link
Member

gnprice commented Aug 8, 2024

Thanks for taking care of this! Looks good — merging.

It's annoying that this will start forcing the use of Flutter versions where #825 appears. That was a reason I'd been procrastinating doing this upgrade. But we can't just hang back on an old Flutter version indefinitely, so given there are concrete reasons we want the upgrade it's time to do it. We'll just tolerate the annoying warning messages until either someone else fixes the affected plugins, or we get tired of the warnings and do so ourselves.

… Oh hey, and digging a bit, it looks like they may indeed have been fixed — the upstream issue on flutter_file_picker just didn't get closed to say so. So I'll see if a quick upgrade handles that.

@gnprice gnprice merged commit 4e4477f into zulip:main Aug 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration review Added by maintainers when PR may be ready for integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants