android: Bump minSdkVersion to 24, aka Android 7 Nougat #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Specifically, when reviewing #317 today I got the error described in (and linking to) that piece of documentation. |
This is the same minimum we have on the zulip-mobile RN app. We've had it at the Flutter default of 19, aka Android 4.4 KitKat. But we're now beginning to bump into the need for "multidex" support: https://docs.flutter.dev/deployment/android#enabling-multidex-support at least in debug builds. The simplest way to do that is to have minSdkVersion at 21 or higher; which is a good prompt for us to bump it to the version we were going to want to bump it to anyway.
chrisbobbe
force-pushed
the
pr-minsdkversion
branch
from
1997f79
to
f4fec85
Compare
|
Thanks! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same minimum we have on the zulip-mobile RN app.
We've had it at the Flutter default of 19, aka Android 4.4 KitKat. But we're now beginning to bump into the need for "multidex" support:
https://docs.flutter.dev/deployment/android#enabling-multidex-support
at least in debug builds. The simplest way to do that is to have minSdkVersion at 21 or higher; which is a good prompt for us to bump it to the version we were going to want to bump it to anyway.