Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

content: Open links in-app on Android #295

Merged
merged 2 commits into from
Nov 7, 2023
Merged

content: Open links in-app on Android #295

merged 2 commits into from
Nov 7, 2023

Commits on Nov 7, 2023

  1. deps: Ensure url_launcher_android version is at least 6.1.0 

    This gets us Android Custom Tabs support, via Rajesh's upstream PR:
  flutter/packages#4739
    @gnprice
    gnprice committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    362f4d1 View commit details
    Browse the repository at this point in the history

  2. content: Open links in-app on Android 

    `url_launcher` plugin now supports the desired behavior, which is using
Android Custom Tabs, so we don't need the workaround of opening the
links in external browser anymore, thus removed them.

Fixes: zulip#279
    @rajveermalviya @gnprice
    rajveermalviya authored and gnprice committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    806a81a View commit details
    Browse the repository at this point in the history