unreads: Enhance performance in _isPresentInStreams

zulip · Aug 9, 2024 · c71160e · c71160e
1 parent 276971b
commit c71160e
Showing 1 changed file with 4 additions and 9 deletions.
diff --git a/lib/model/unreads.dart b/lib/model/unreads.dart
@@ -259,7 +259,7 @@ class Unreads extends ChangeNotifier {
     final bool isRead = event.flags.contains(MessageFlag.read);
     assert(() {
       if (!oldUnreadsMissing && !event.messageIds.every((messageId) {
-        final isUnreadLocally = _slowIsPresentInDms(messageId) || _slowIsPresentInStreams(messageId);
+        final isUnreadLocally = _slowIsPresentInDms(messageId) || _isPresentInStreams(messageId);
         return isUnreadLocally == !isRead;
       })) {
         // If this happens, then either:
@@ -335,7 +335,7 @@ class Unreads extends ChangeNotifier {
           case UpdateMessageFlagsAddEvent():
             mentions.addAll(
               event.messages.where(
-                (messageId) => _slowIsPresentInStreams(messageId) || _slowIsPresentInDms(messageId),
+                (messageId) => _isPresentInStreams(messageId) || _slowIsPresentInDms(messageId),
               ),
             );
 
@@ -434,13 +434,8 @@ class Unreads extends ChangeNotifier {
     notifyListeners();
   }
 
-  // TODO use efficient lookups
-  bool _slowIsPresentInStreams(int messageId) {
-    return streams.values.any(
-      (topics) => topics.values.any(
-        (messageIds) => messageIds.contains(messageId),
-      ),
-    );
+  bool _isPresentInStreams(int messageId) {
+    return _reverseStreamsLookup.containsKey(messageId);
   }
 
   void _addLastInStreamTopic(int messageId, int streamId, String topic) {