Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: Add get_stream_email_address(). #817

Merged
merged 1 commit into from
Jun 16, 2024

Conversation

rsashank
Copy link
Member

Python wrapper function for the new endpoint introduced in ZFL 226 to fetch a stream's email address. This could enhance the ease of making calls within zulip terminal and potentially other clients.

zulip/zulip/__init__.py Outdated Show resolved Hide resolved
@rsashank rsashank force-pushed the stream_email_address branch 2 times, most recently from 20e2aa7 to b491e9d Compare December 16, 2023 09:34
zulip/zulip/__init__.py Outdated Show resolved Hide resolved
@neiljp
Copy link
Contributor

neiljp commented Dec 19, 2023

@timabbott LGTM based on manual test, and given lack of old-server fallbacks and inconsistent nearby styling to compare to (see below).

It would be good to get this out, unless more API calls would be beneficial to add based on new changes/features in 7.5+/8.0?

It looks like we don't note/handle lack of features in older servers in zulip, ie. on an older server this call would simply fail with this call - the only use of feature_level is for method parameters, not the presence of the feature.

Reviewing adjacent code, we're not particularly consistent with style:

  • absence/presence of responses to examples
  • regular/unicode strings in example responses (eg. u'result': u'success' vs dropping u)
  • example layout (blank lines, or no lines, from 'Example usage' to code)
  • historically I thought we had call_endpoint calls split over lines (possibly just black?)

@timabbott timabbott merged commit 868ce8f into zulip:main Jun 16, 2024
13 checks passed
@timabbott
Copy link
Member

Merged, thanks @rsashank!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants