api: Implement PATCH /realm endpoint. #605
Conversation
| ''' | ||
| Example usage: | ||
|
|
||
| >>> client.update_realm({'digest_weekday': 0', 'signup_notifications_stream_id': -1}) |
There was a problem hiding this comment.
The quoting here seems likely hand-written and wrong. E.g. the 0 with a quote on only one side of it.
Please be sure to test your examples!
There was a problem hiding this comment.
oops, sorry! I write it by hand indeed, actually, I copy/paste the example of the /realm documentation on zulip.yaml. I'll do an actual request and copy the result here.
There was a problem hiding this comment.
I guess this still isn't resolved.
|
Generally looks good, but posted a comment on the example :) |
|
Heads up @clarammdantas, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
|
@clarammdantas can you rebase this one? |
|
Oh, I completely forgot about this! Sorrry, I'm rebasing it and fiing that example. |
|
Looks like we can rebase it and do some extra testings to get this merged. LGTM overall. |
|
@clarammdantas do you have time to finish this up? |
This adds API binds for
/realmendpoint.