bridges: Check if bot is subscribed to relevant stream. #571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orientor
changed the title
|
LGTM; @showell |
|
This seems like a straightforward change. @orientor Can you fix the merge conflicts here? |
Check whether the zulip bot is subscribed to the stream meant for sending messages before logging in to Matrix.
…reams. Check whether both the bots are subscribed to their respective streams designated for sending messages before starting the bridge. Fixes zulip#568.
|
@showell rebased. |
rht
reviewed
Aug 11, 2020
| @@ -9,6 +9,16 @@ import interrealm_bridge_config | |||
|
|
|||
| from typing import Any, Callable, Dict | |||
|
|
|||
| def check_subscription_or_die(zulip_client, stream): | |||
| # type: (zulip.Client, str) -> None | |||
There was a problem hiding this comment.
The annotation needs to be changed to Python 3 version. Also applied to the other check_subscription_or_die.
|
Heads up @orientor, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks if the bots are subscribed to their revelant streams during startup of various bridges.
Fixes #568 .