Skip to content

[WIP] bots: Create trivia_quiz_game bot #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

fremiller
Copy link
Contributor

@fremiller fremiller commented Mar 28, 2020

This is a trivia bot, but formatted like a competitive game instead of individual questions

@zulipbot zulipbot added size: XL and removed size: M labels Mar 28, 2020
@zulipbot zulipbot added size: L and removed size: XL labels Mar 28, 2020
@fremiller fremiller force-pushed the trivia-quiz-game branch 4 times, most recently from 892ff28 to 4382138 Compare March 29, 2020 14:01
@zulipbot zulipbot added size: XL and removed size: L labels Mar 29, 2020
@fremiller
Copy link
Contributor Author

I have done the bot, I just need to rewrite the tests

@fremiller
Copy link
Contributor Author

fremiller commented Apr 1, 2020

I've made some changes to game_handler

  1. Player colours / tokens are not required for a game
  2. A game "board" can include widget_content. This is done by returning (str, str) instead of str in parse_board
  3. move_data has been added. This is an extra parameter to alert_move_message which contains data returned by make_move
  4. Exceptions which occur in a game instance are now caught separately and cause the game to end

I haven't gotten onto writing the tests yet. I just switched my development environment from wsl to windows, which has made everything way faster (tests & autocompletion took forever on wsl)

@fremiller fremiller force-pushed the trivia-quiz-game branch 2 times, most recently from 8a9d7b3 to 5203511 Compare April 1, 2020 14:14
@fremiller fremiller changed the title [WIP] bots: Port trivia_quiz to game_handler [WIP] bots: Create trivia_quiz_game bot Apr 1, 2020
@fremiller fremiller force-pushed the trivia-quiz-game branch 2 times, most recently from 741f53c to 7a66da1 Compare April 1, 2020 14:41
@zulipbot
Copy link
Member

Heads up @fishfred, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/master branch and resolve your pull request's merge conflicts accordingly.

@showell
Copy link
Contributor

showell commented Apr 24, 2020

@fishfred Sorry I haven't gotten around to merging this--I just haven't found time to test it out yet. Can you rebase to deal with the conflicts here?

@fremiller
Copy link
Contributor Author

@showell No worries, there are a few changes I still want to make, I just have to finish off some projects for university so I haven't had time to. I will hopefully get some time to finish this weekend

@fremiller fremiller force-pushed the trivia-quiz-game branch 2 times, most recently from ee2bc20 to 74a2e2f Compare April 29, 2020 10:13
provision: Fix source command on Windows
@showell
Copy link
Contributor

showell commented Sep 20, 2020

@fishfred Hope all is well! I am just pinging you on this, since this got blocked a while ago by you getting busy with university stuff. My timing is off, but I am wondering if you have time to work this again?

@fremiller
Copy link
Contributor Author

Yeah, I've still got a couple of weeks until term starts so I can work on it

@fremiller
Copy link
Contributor Author

There are some things in game_handler which I think could be better so I might refactor that quickly before continuing work on this

@fremiller
Copy link
Contributor Author

Ah I might do that after as it would make the PR quite confusing. There shouldn't need to be any changes to bots so I may as well just do it after.

@showell
Copy link
Contributor

showell commented Sep 21, 2020

Sounds good, have fun!

@PIG208
Copy link
Member

PIG208 commented Jun 14, 2021

@fishfred Are you still wishing to work on this and do a rebase?

@fremiller
Copy link
Contributor Author

@PIG208 I'd have enough time to just do a rebase, but I don't have enough time if the PR needs more work than that
I'll clone it again and take a look

@fremiller
Copy link
Contributor Author

@PIG208 Sorry I tried working on this a week ago but I don't have enough time to continue working on it right now

@showell
Copy link
Contributor

showell commented Jun 29, 2021

No worries, @fishfred! Thanks for taking a look at it.

@zulipbot
Copy link
Member

Heads up @fremiller, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants