Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ds): File extension detection misidentifies types #3182

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

t1m0thyj
Copy link
Member

@t1m0thyj t1m0thyj commented Oct 4, 2024

Proposed changes

Fixes #3181

Release Notes

Milestone: 3.0.1

Changelog: Fixed an issue where automatic file extension detection identified file types incorrectly

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

Further comments

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.79%. Comparing base (77235a3) to head (1f7fb0e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3182      +/-   ##
==========================================
- Coverage   92.79%   92.79%   -0.01%     
==========================================
  Files         113      113              
  Lines       11670    11666       -4     
  Branches     2603     2499     -104     
==========================================
- Hits        10829    10825       -4     
  Misses        839      839              
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

traeok
traeok previously approved these changes Oct 4, 2024
Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that this is still in draft, but the code and test change LGTM.
Thanks for quickly addressing this oversight

@t1m0thyj t1m0thyj marked this pull request as ready for review October 4, 2024 12:20
Copy link

github-actions bot commented Oct 4, 2024

📅 Suggested merge-by date: 10/18/2024

Signed-off-by: Timothy Johnson <[email protected]>
Copy link

sonarcloud bot commented Oct 4, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Review/QA
Development

Successfully merging this pull request may close these issues.

V3.0.0 File extension detection misidentifies types
2 participants