-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ds): File extension detection misidentifies types #3182
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Timothy Johnson <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3182 +/- ##
==========================================
- Coverage 92.79% 92.79% -0.01%
==========================================
Files 113 113
Lines 11670 11666 -4
Branches 2603 2499 -104
==========================================
- Hits 10829 10825 -4
Misses 839 839
Partials 2 2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know that this is still in draft, but the code and test change LGTM.
Thanks for quickly addressing this oversight
📅 Suggested merge-by date: 10/18/2024 |
Signed-off-by: Timothy Johnson <[email protected]>
Quality Gate passedIssues Measures |
Proposed changes
Fixes #3181
Release Notes
Milestone: 3.0.1
Changelog: Fixed an issue where automatic file extension detection identified file types incorrectly
Types of changes
Checklist
General
yarn workspace vscode-extension-for-zowe vscode:prepublish
pnpm --filter vscode-extension-for-zowe vscode:prepublish
Code coverage
Deployment
Further comments