Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Zowe SDKs to remove prerelease peer deps #3177

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

t1m0thyj
Copy link
Member

@t1m0thyj t1m0thyj commented Oct 3, 2024

Update Zowe SDKs to consume the following bug fixes:

@t1m0thyj t1m0thyj added the no-changelog Add to PR's that don't require a CHANGELOG update label Oct 3, 2024
Copy link

github-actions bot commented Oct 3, 2024

📅 Suggested merge-by date: 10/17/2024

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.79%. Comparing base (7b5fd8c) to head (0fd09cb).

Additional details and impacted files
@@                   Coverage Diff                    @@
##           fix/remove-vsce-samples    #3177   +/-   ##
========================================================
  Coverage                    92.79%   92.79%           
========================================================
  Files                          113      113           
  Lines                        11663    11663           
  Branches                      2593     2500   -93     
========================================================
  Hits                         10823    10823           
  Misses                         838      838           
  Partials                         2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Oct 3, 2024

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Timothy!

I noticed the lint stage is failing - I wasn't sure when we wanted to implement the replacement API call for issueTsoCommand. We could update it to use the new API, disable the lint warning to get the stage passing, or keep it as-is for now 😋

I see the warning was disabled as soon as I finished the review - thanks for addressing that

@t1m0thyj t1m0thyj merged commit f83f0f9 into fix/remove-vsce-samples Oct 3, 2024
26 checks passed
@t1m0thyj t1m0thyj deleted the fix/update-zowe-sdks branch October 3, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Add to PR's that don't require a CHANGELOG update size/L
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

2 participants