-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Zowe SDKs to remove prerelease peer deps #3177
Conversation
Signed-off-by: Timothy Johnson <[email protected]>
📅 Suggested merge-by date: 10/17/2024 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fix/remove-vsce-samples #3177 +/- ##
========================================================
Coverage 92.79% 92.79%
========================================================
Files 113 113
Lines 11663 11663
Branches 2593 2500 -93
========================================================
Hits 10823 10823
Misses 838 838
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Timothy Johnson <[email protected]>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks Timothy!
I noticed the lint stage is failing - I wasn't sure when we wanted to implement the replacement API call for issueTsoCommand
. We could update it to use the new API, disable the lint warning to get the stage passing, or keep it as-is for now 😋
I see the warning was disabled as soon as I finished the review - thanks for addressing that
Update Zowe SDKs to consume the following bug fixes: