Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port #2768 V2 PR to V3(main) #3145

Merged
merged 4 commits into from
Sep 24, 2024
Merged

Port #2768 V2 PR to V3(main) #3145

merged 4 commits into from
Sep 24, 2024

Conversation

likhithanimma1
Copy link
Contributor

Proposed changes

Port #2768 to main v3

Release Notes

Milestone:

Changelog:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

Further comments

Signed-off-by: likhithanimma1 <[email protected]>
Copy link

📅 Suggested merge-by date: 10/8/2024

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.77%. Comparing base (f3d5395) to head (0341b9e).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...ackages/zowe-explorer/src/trees/job/ZoweJobNode.ts 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3145      +/-   ##
==========================================
- Coverage   92.77%   92.77%   -0.01%     
==========================================
  Files         113      113              
  Lines       11649    11662      +13     
  Branches     2446     2451       +5     
==========================================
+ Hits        10807    10819      +12     
- Misses        840      841       +1     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: likhithanimma1 <[email protected]>
@likhithanimma1 likhithanimma1 changed the title Port #2768 to V2 PR to V3(main) Port #2768 V2 PR to V3(main) Sep 24, 2024
Copy link
Contributor

@SanthoshiBoyina1 SanthoshiBoyina1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @likhithanimma1

Copy link

sonarcloud bot commented Sep 24, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
19.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for porting the fix @likhithanimma1

@JillieBeanSim JillieBeanSim added the no-changelog Add to PR's that don't require a CHANGELOG update label Sep 24, 2024
@JillieBeanSim JillieBeanSim merged commit 1ea9fab into main Sep 24, 2024
30 of 32 checks passed
@JillieBeanSim JillieBeanSim deleted the port-2768 branch September 24, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Add to PR's that don't require a CHANGELOG update size/M
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

3 participants