Update dev deps and fix code smells for V3

[t1m0thyj]

Proposed changes

Resolves security alerts and code smells found by GitHub now that V3 code is in the main branch.

Release Notes

Milestone: 3.0.0

Changelog: N/A

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• Enhancement (non-breaking change which adds or improves functionality)
• Breaking change (a change that would cause existing functionality to not work as expected)
• Documentation (Markdown, README updates)
• Other (please specify above in "Proposed changes" section)

Checklist

General

• I have read the CONTRIBUTOR GUIDANCE wiki
• All PR dependencies have been merged and published (if applicable)
• A GIF or screenshot is included in the PR for visual changes
• The pre-publish command has been executed:
  • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
  • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

• There is coverage for the code that I have added
• I have added new test cases and they are passing
• I have manually tested the changes

Deployment

• I have added developer documentation (if applicable)
• Documentation should be added to Zowe Docs
  • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
  • Otherwise, please check with the rest of the squad about any needed documentation before merging.
• These changes may need ported to the appropriate branches (list here):

Further comments

[github-actions]

📅 Suggested merge-by date: 10/3/2024

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.60%. Comparing base (d464418) to head (afb5099).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3130      +/-   ##
==========================================
- Coverage   92.60%   92.60%   -0.01%     
==========================================
  Files         113      113              
  Lines       11658    11657       -1     
  Branches     2487     2591     +104     
==========================================
- Hits        10796    10795       -1     
  Misses        860      860              
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[JillieBeanSim]

LGTM! thanks @t1m0thyj

[traeok]

Changes LGTM, thanks Timothy for the fixes & updates 😋

[traeok]

Thanks for cleaning this logic up 😁

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.4% Duplication on New Code

See analysis details on SonarCloud

[traeok]

Had a quick question but nothing that should hold this PR back. Thanks Timothy for the updates & code smell fixes

[traeok]

Question for my own clarification: could we remove some of the logic in this script by defining the file suffix before looking over the entries in the JSON? E.g.:

const fileSuffix = langId ? `.${langId}.json` : ".json";

Then the same file suffix could be appended to the package.nls, poeditor and bundle.l10n files to retrieve the contents for the given language ID.

I didn't notice much of a difference between the two branches when doing the langId checks, but if we have to keep the logic separate then feel free to disregard this.

[JillieBeanSim]

can create a follow up story if decided to make the updates.