Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v3): Port jobs context menu changes from 2689 #2743

Merged
merged 4 commits into from
Feb 28, 2024
Merged

Conversation

adam-wolfe
Copy link
Contributor

@adam-wolfe adam-wolfe commented Feb 25, 2024

Proposed changes

  1. Modified the changelog to have the note for the adjusted Jobs tree context menu for the next V3 release
  2. Added internationalization string for jobs.filterBy
  3. Rearranged the order of items on the jobs context menu (see fix(jobs-tree-context-menu): Adjust menu item order for consistency #2689 for a screenshot)
  4. Removed context menu items to edit and delete the profile

Resolves #2670 for v3.

Release Notes

Milestone:

Changelog:

Adjusted order of 'Manage Profile' and 'Edit History' in the jobs tree's context menu to match the other trees.

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found
  • I have added necessary documentation (if appropriate)
  • Any PR dependencies have been merged and published (if appropriate)

Further comments

traeok
traeok previously approved these changes Feb 26, 2024
Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @adam-wolfe!

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.42%. Comparing base (cb46f50) to head (2d10be2).

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2743   +/-   ##
=======================================
  Coverage   93.42%   93.42%           
=======================================
  Files         109      109           
  Lines       10228    10228           
  Branches     2173     2075   -98     
=======================================
  Hits         9555     9555           
  Misses        672      672           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

Copy link

sonarcloud bot commented Feb 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@zFernand0 zFernand0 merged commit 66349ba into next Feb 28, 2024
18 of 19 checks passed
@zFernand0 zFernand0 deleted the fix/port-2689 branch February 28, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

3 participants