Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Theia Support #2706

Merged
merged 8 commits into from
Feb 20, 2024
Merged

Remove Theia Support #2706

merged 8 commits into from
Feb 20, 2024

Conversation

likhithanimma1
Copy link
Contributor

Proposed changes

Removing code that deals with Theia environment as to drop the Theia support with v3

Release Notes

Milestone:

Changelog:

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found
  • I have added necessary documentation (if appropriate)
  • Any PR dependencies have been merged and published (if appropriate)

Further comments

Signed-off-by: likhithanimma1 <[email protected]>
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (087a324) 93.27% compared to head (e471eb0) 93.34%.

Files Patch % Lines
packages/zowe-explorer/src/shared/actions.ts 76.92% 3 Missing ⚠️
packages/zowe-explorer/src/uss/USSTree.ts 85.71% 2 Missing ⚠️
...ges/zowe-explorer/src/command/MvsCommandHandler.ts 94.11% 1 Missing ⚠️
...ges/zowe-explorer/src/command/TsoCommandHandler.ts 94.11% 1 Missing ⚠️
...es/zowe-explorer/src/command/UnixCommandHandler.ts 94.11% 1 Missing ⚠️
packages/zowe-explorer/src/dataset/DatasetTree.ts 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2706      +/-   ##
==========================================
+ Coverage   93.27%   93.34%   +0.06%     
==========================================
  Files         109      109              
  Lines       10294    10203      -91     
  Branches     2223     2095     -128     
==========================================
- Hits         9602     9524      -78     
+ Misses        691      678      -13     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@likhithanimma1 likhithanimma1 marked this pull request as ready for review February 8, 2024 17:37
@JillieBeanSim JillieBeanSim added this to the v3 pre-releases milestone Feb 8, 2024
@JillieBeanSim JillieBeanSim linked an issue Feb 8, 2024 that may be closed by this pull request
Signed-off-by: Billie Simmons <[email protected]>
Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when doing a search on the repo for isTheia in this branch a lot shows in the results window, we will want to have all of this removed for this story or can split the story across packages if gets too big

Signed-off-by: likhithanimma1 <[email protected]>
Signed-off-by: likhithanimma1 <[email protected]>
Copy link

sonarcloud bot commented Feb 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.5% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

Theia seems to be handling quickpicks kind of ok.
and I confirmed that everything ISTHEIA related was removed from the VSIX that I used to test in Theia 😋

Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks @likhithanimma1 for these updates
I will create a follow up issue for removal of some documentation in READMEs and launches and other items I see but not necessarily code related.

@JillieBeanSim JillieBeanSim merged commit 0d69b7c into next Feb 20, 2024
20 of 21 checks passed
@JillieBeanSim JillieBeanSim deleted the Remove-Theia branch February 20, 2024 13:38
@JillieBeanSim
Copy link
Contributor

follow up story #2726

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

Remove code related to Theia support
3 participants