-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Theia Support #2706
Remove Theia Support #2706
Conversation
Signed-off-by: likhithanimma1 <[email protected]>
5f6bc4c
to
f43b831
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## next #2706 +/- ##
==========================================
+ Coverage 93.27% 93.34% +0.06%
==========================================
Files 109 109
Lines 10294 10203 -91
Branches 2223 2095 -128
==========================================
- Hits 9602 9524 -78
+ Misses 691 678 -13
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Billie Simmons <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when doing a search on the repo for isTheia in this branch a lot shows in the results window, we will want to have all of this removed for this story or can split the story across packages if gets too big
Signed-off-by: likhithanimma1 <[email protected]>
Signed-off-by: likhithanimma1 <[email protected]>
Signed-off-by: likhithanimma1 <[email protected]>
Signed-off-by: likhithanimma1 <[email protected]>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😋
Theia seems to be handling quickpicks kind of ok.
and I confirmed that everything ISTHEIA
related was removed from the VSIX that I used to test in Theia 😋
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, thanks @likhithanimma1 for these updates
I will create a follow up issue for removal of some documentation in READMEs and launches and other items I see but not necessarily code related.
follow up story #2726 |
Proposed changes
Removing code that deals with Theia environment as to drop the Theia support with v3
Release Notes
Milestone:
Changelog:
Types of changes
What types of changes does your code introduce to Zowe Explorer?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the revieweryarn workspace vscode-extension-for-zowe vscode:prepublish
has been executedFurther comments