Local filtering of Jobs with exec-member field #2651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Santhoshi Boyina <[email protected]>
SanthoshiBoyina
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2651 +/- ##
=======================================
Coverage 93.30% 93.30%
=======================================
Files 102 102
Lines 10503 10506 +3
Branches 2248 2251 +3
=======================================
+ Hits 9800 9803 +3
Misses 702 702
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Santhoshi Boyina <[email protected]>
SanthoshiBoyina
changed the title
SanthoshiBoyina
requested review from
JillieBeanSim,
t1m0thyj,
adam-wolfe,
rudyflores,
traeok and
likhithanimma1
traeok
previously approved these changes
Jan 5, 2024
There was a problem hiding this comment.
Looks good, thanks @SanthoshiBoyina! Left a comment regarding a check in the onDidChangeValue event, but not a required change.
Signed-off-by: Santhoshi Boyina <[email protected]>
traeok
approved these changes
Jan 8, 2024
|
Please retry analysis of this Pull-Request directly on SonarCloud |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Currently, the Local Filtering of Jobs is based on jobid, jobname and return code. With these proposed changes filtering of jobs is even possible with exec-member field.
Release Notes
Milestone:
Changelog:
Types of changes
What types of changes does your code introduce to Zowe Explorer?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the revieweryarn workspace vscode-extension-for-zowe vscode:prepublishhas been executedFurther comments