Prepare v3 pre-release #2648

JillieBeanSim · 2024-01-04T21:39:59Z

Proposed changes

Update version for pre-release 3.0.0-next.202401041628

Release Notes

Milestone: vNext

Changelog: n/a

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

Further comments

Signed-off-by: Billie Simmons <[email protected]>

codecov · 2024-01-04T21:42:52Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (75e848f) 93.42% compared to head (72dcc54) 93.42%.

Additional details and impacted files

@@           Coverage Diff           @@
##             next    #2648   +/-   ##
=======================================
  Coverage   93.42%   93.42%           
=======================================
  Files         109      109           
  Lines       10237    10237           
  Branches     2134     2134           
=======================================
  Hits         9564     9564           
  Misses        672      672           
  Partials        1        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

zFernand0

LGTM! 😋
Should we remove the Theia workflow form the next branch?

JillieBeanSim · 2024-01-05T20:21:47Z

I created an issue other day for removing Theia checks and accompanying code
#2647

Signed-off-by: Billie Simmons <[email protected]>

zFernand0 · 2024-01-08T14:36:22Z

I created an issue other day for removing Theia checks and accompanying code #2647

Thanks for removing the workflow. And yes, we can target all other code changes around dropping Theia support in that issue 😋

JillieBeanSim · 2024-01-08T14:37:40Z

I see an issue on next branch with the Issue Unix command with following error via USS treeview. Will investigate

JillieBeanSim · 2024-01-08T14:39:00Z

also this during startup of extension

zFernand0 · 2024-01-08T15:04:31Z

I see an issue on next branch with the Issue Unix command with following error via USS treeview. Will investigate

hey @JillieBeanSim,
I noted this behavior in the following issue:

feat(unix-cmd): User Experience improvements #2643

I didn't see it as a showstopper (for the PR that introduced multi-ssh profile support)

zFernand0 · 2024-01-08T15:05:46Z

also this during startup of extension

oh, and this one might be related to...

Startup for Zowe Explorer and ZE extensions can be slow #2577

JillieBeanSim · 2024-01-09T14:09:20Z

also this during startup of extension

oh, and this one might be related to...

Startup for Zowe Explorer and ZE extensions can be slow #2577

I think something went wrong with merge from main for the command error on start up since this isn't experienced with main.
The other was due to a token in base and trying to share with ssh profile after looking into it

Signed-off-by: Billie Simmons <[email protected]>

JillieBeanSim · 2024-01-09T14:32:36Z

the command was in the "view/item/context" array but not in the "command" array of package.json where they are initially created and also not registered during activation. It also doesn't exist on main branch, so removing.

sonarcloud · 2024-01-09T14:34:48Z

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

zFernand0 · 2024-01-09T15:14:33Z

Hey @JillieBeanSim,
Thanks for looking into this and fixing it! 🥳

Regarding:

I think something went wrong with merge from main

@traeok, @t1m0thyj, do you think that fewer of these cases will occur if the improvements to the deployment workflow (that you guys brought up) were rolled out?

t1m0thyj

LGTM, thanks @JillieBeanSim!

t1m0thyj · 2024-01-12T17:23:12Z

packages/zowe-explorer/package.json

@@ -1405,11 +1405,6 @@
          "command": "zowe.jobs.editSession",
          "group": "099_zowe_jobsProfileModification@0"
        },
-        {
-          "when": "view == zowe.jobs.explorer && viewItem =~ /^(?!.*_fav.*)server.*/",
-          "command": "zowe.jobs.removeJobsSession",


Looks like this menu item was referencing a non-existent command, so makes sense to remove it 👍

traeok · 2024-01-12T17:27:46Z

@traeok, @t1m0thyj, do you think that fewer of these cases will occur if the improvements to the deployment workflow (that you guys brought up) were rolled out?

Yep, this would minimize the amount of commits in merge PRs since next would be based on main (once v3 is GA)

traeok

LGTM, thanks @JillieBeanSim 😁

JillieBeanSim · 2024-01-12T17:46:22Z

Thanks @t1m0thyj & @traeok for reviewing so quickly

github-actions · 2024-01-12T17:49:33Z

Release succeeded for the next branch. 🎉

The following packages have been published:

_{Powered by Octorelease 🚀}

update version 3.0.0-next.202401041628

7c8f844

Signed-off-by: Billie Simmons <[email protected]>

JillieBeanSim added v3 no-changelog Add to PR's that don't require a CHANGELOG update labels Jan 4, 2024

JillieBeanSim added this to the v3 pre-releases milestone Jan 4, 2024

JillieBeanSim self-assigned this Jan 4, 2024

JillieBeanSim marked this pull request as ready for review January 4, 2024 21:55

JillieBeanSim requested review from t1m0thyj, traeok, rudyflores, adam-wolfe, zFernand0, SanthoshiBoyina and likhithanimma1 January 4, 2024 21:55

zFernand0 previously approved these changes Jan 5, 2024

View reviewed changes

remove Theia workflow and update v3 doc

701009b

Signed-off-by: Billie Simmons <[email protected]>

JillieBeanSim dismissed zFernand0’s stale review via 701009b January 5, 2024 21:42

JillieBeanSim requested a review from zFernand0 January 5, 2024 21:43

zFernand0 previously approved these changes Jan 8, 2024

View reviewed changes

JillieBeanSim marked this pull request as draft January 8, 2024 14:36

remove unregistered command

72dcc54

Signed-off-by: Billie Simmons <[email protected]>

JillieBeanSim dismissed zFernand0’s stale review via 72dcc54 January 9, 2024 14:33

JillieBeanSim marked this pull request as ready for review January 9, 2024 14:34

JillieBeanSim requested a review from zFernand0 January 9, 2024 14:34

t1m0thyj approved these changes Jan 12, 2024

View reviewed changes

traeok approved these changes Jan 12, 2024

View reviewed changes

JillieBeanSim merged commit 1556789 into next Jan 12, 2024
20 checks passed

JillieBeanSim deleted the publish/3.0.0-next-prerelease branch January 12, 2024 17:46

github-actions bot added the released label Jan 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prepare v3 pre-release #2648

Prepare v3 pre-release #2648

JillieBeanSim commented Jan 4, 2024 •

edited

Loading

codecov bot commented Jan 4, 2024 •

edited

Loading

zFernand0 left a comment

JillieBeanSim commented Jan 5, 2024

zFernand0 commented Jan 8, 2024

JillieBeanSim commented Jan 8, 2024

JillieBeanSim commented Jan 8, 2024

zFernand0 commented Jan 8, 2024 •

edited

Loading

zFernand0 commented Jan 8, 2024

JillieBeanSim commented Jan 9, 2024 •

edited

Loading

JillieBeanSim commented Jan 9, 2024

sonarcloud bot commented Jan 9, 2024

zFernand0 commented Jan 9, 2024

t1m0thyj left a comment

t1m0thyj Jan 12, 2024

traeok commented Jan 12, 2024 •

edited

Loading

traeok left a comment •

edited

Loading

JillieBeanSim commented Jan 12, 2024

github-actions bot commented Jan 12, 2024

Prepare v3 pre-release #2648

Prepare v3 pre-release #2648

Conversation

JillieBeanSim commented Jan 4, 2024 • edited Loading

Proposed changes

Release Notes

Types of changes

Checklist

Further comments

codecov bot commented Jan 4, 2024 • edited Loading

Codecov Report

zFernand0 left a comment

Choose a reason for hiding this comment

JillieBeanSim commented Jan 5, 2024

zFernand0 commented Jan 8, 2024

JillieBeanSim commented Jan 8, 2024

JillieBeanSim commented Jan 8, 2024

zFernand0 commented Jan 8, 2024 • edited Loading

zFernand0 commented Jan 8, 2024

JillieBeanSim commented Jan 9, 2024 • edited Loading

JillieBeanSim commented Jan 9, 2024

sonarcloud bot commented Jan 9, 2024

Quality Gate passed

zFernand0 commented Jan 9, 2024

t1m0thyj left a comment

Choose a reason for hiding this comment

t1m0thyj Jan 12, 2024

Choose a reason for hiding this comment

traeok commented Jan 12, 2024 • edited Loading

traeok left a comment • edited Loading

Choose a reason for hiding this comment

JillieBeanSim commented Jan 12, 2024

github-actions bot commented Jan 12, 2024

JillieBeanSim commented Jan 4, 2024 •

edited

Loading

codecov bot commented Jan 4, 2024 •

edited

Loading

zFernand0 commented Jan 8, 2024 •

edited

Loading

JillieBeanSim commented Jan 9, 2024 •

edited

Loading

traeok commented Jan 12, 2024 •

edited

Loading

traeok left a comment •

edited

Loading