Submit as JCL: check for profile before presenting quick pick #2646
Conversation
Signed-off-by: Likhitha Nimma <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Likhitha Nimma <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2646 +/- ##
==========================================
+ Coverage 93.26% 93.30% +0.04%
==========================================
Files 102 102
Lines 10497 10503 +6
Branches 2245 2248 +3
==========================================
+ Hits 9790 9800 +10
+ Misses 706 702 -4
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Likhitha Nimma <[email protected]>
Signed-off-by: Likhitha Nimma <[email protected]>
Signed-off-by: Likhitha Nimma <[email protected]>
Signed-off-by: Likhitha Nimma <[email protected]>
Signed-off-by: Likhitha Nimma <[email protected]>
Signed-off-by: Likhitha Nimma <[email protected]>
likhithanimma1
requested review from
JillieBeanSim,
rudyflores,
zFernand0,
t1m0thyj,
SanthoshiBoyina,
traeok and
adam-wolfe
There was a problem hiding this comment.
This looks good for this workflow, thanks @likhithanimma1 for the update. Would you mind updating the CHANGELOG please?
Signed-off-by: Likhitha Nimma <[email protected]>
There was a problem hiding this comment.
Tested and LGTM - just noticed an outdated ESLint comment during review, will approve once removed 🙂
Thanks @likhithanimma1!
Signed-off-by: Likhitha Nimma <[email protected]>
| } else if (profileNamesList.length > 0) { | ||
| sessProfileName = profileNamesList[0]; |
There was a problem hiding this comment.
This is really cool! 😋
Should we do the same for other types of profiles across Zowe Explorer?
|
Proposed changes
Fixes # #2628
Since we store temp. files based on their profile, we could determine the profile without spawning a quick pick for user input.
Release Notes
Milestone:
Changelog:
Types of changes
What types of changes does your code introduce to Zowe Explorer?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the revieweryarn workspace vscode-extension-for-zowe vscode:prepublishhas been executedFurther comments