Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cfg): Allow extenders to contribute to Zowe schema during activation #2615

Merged
merged 35 commits into from
Feb 20, 2024

Conversation

traeok
Copy link
Member

@traeok traeok commented Dec 11, 2023

Proposed changes

This PR allows extenders to contribute new profile types to the Zowe schema during activation.

How to test:

  • Install the Zowe Explorer FTP extension while the Zowe Explorer VSIX (from this PR) is installed
  • After the FTP extension is activated, a new file should be created in the user's Zowe folder (extenders.json)
    • The contents of this file should contain the zftp profile type, with the from array containing Zowe Explorer (for VS Code)

NOTE: I recommend uninstalling the FTP extension and completely reloading VS Code before trying the steps above. VS Code will not always replace the contents of the extension folder if the same version is already installed.

Release Notes

Milestone: 2.15.0

Changelog:

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (cddfa38) 93.25% compared to head (8a539ef) 93.26%.

Files Patch % Lines
packages/zowe-explorer/src/ZoweExplorerExtender.ts 90.90% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2615      +/-   ##
==========================================
+ Coverage   93.25%   93.26%   +0.01%     
==========================================
  Files         102      102              
  Lines       10562    10579      +17     
  Branches     2189     2196       +7     
==========================================
+ Hits         9850     9867      +17     
  Misses        711      711              
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@traeok traeok marked this pull request as ready for review December 11, 2023 20:25
@zFernand0 zFernand0 added this to the v2.14.0 milestone Dec 12, 2023
@traeok traeok marked this pull request as draft January 2, 2024 15:34
@traeok traeok linked an issue Jan 9, 2024 that may be closed by this pull request
@JillieBeanSim JillieBeanSim modified the milestones: v2.14.0, v2.15.0 Jan 23, 2024
@traeok traeok marked this pull request as ready for review February 14, 2024 15:48
@traeok
Copy link
Member Author

traeok commented Feb 14, 2024

Okay, good to go on this one now. Sorry for the delays.

t1m0thyj
t1m0thyj previously approved these changes Feb 16, 2024
Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @traeok!

Will re-approve if needed after conflicts have been resolved

packages/zowe-explorer/__mocks__/mockCreators/shared.ts Outdated Show resolved Hide resolved
packages/zowe-explorer/src/ZoweExplorerExtender.ts Outdated Show resolved Hide resolved
@traeok traeok requested a review from t1m0thyj February 16, 2024 16:16
Copy link

sonarcloud bot commented Feb 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks @traeok for this enhancement

@JillieBeanSim JillieBeanSim merged commit 6c900e7 into main Feb 20, 2024
23 of 25 checks passed
@JillieBeanSim JillieBeanSim deleted the feat/cfg/update-schema branch February 20, 2024 13:03
@JillieBeanSim
Copy link
Contributor

@traeok don't forget to port these changes to next branch, thanks 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

Add custom schemas provided by extenders to the schema.json file
4 participants