Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.13.0 Release #2613

Merged
merged 1 commit into from
Dec 12, 2023
Merged

2.13.0 Release #2613

merged 1 commit into from
Dec 12, 2023

Conversation

JillieBeanSim
Copy link
Contributor

Proposed changes

Prepare 2.13.0 release

Milestone: 2.13.0

Changelog: n/a

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found
  • I have added necessary documentation (if appropriate)
  • Any PR dependencies have been merged and published (if appropriate)

Further comments

Signed-off-by: Billie Simmons <[email protected]>
@JillieBeanSim JillieBeanSim added the no-changelog Add to PR's that don't require a CHANGELOG update label Dec 8, 2023
@JillieBeanSim JillieBeanSim added this to the v2.13.0 milestone Dec 8, 2023
@JillieBeanSim JillieBeanSim self-assigned this Dec 8, 2023
Copy link

sonarcloud bot commented Dec 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1f1e638) 93.21% compared to head (b0fac15) 93.21%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2613   +/-   ##
=======================================
  Coverage   93.21%   93.21%           
=======================================
  Files         104      104           
  Lines       10412    10412           
  Branches     2200     2200           
=======================================
  Hits         9706     9706           
  Misses        705      705           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JillieBeanSim for preparing the v2.13 release 🙂

yarn.lock Show resolved Hide resolved
@JillieBeanSim JillieBeanSim marked this pull request as ready for review December 12, 2023 12:59
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not found any showstoppers on the release.
However, there is one small item that I haven't had a chance to thoroughly test.
I'm referring to the addition of what seems to me like a new required method to the zowe-explorer-api package in the PR below:

That being said, I'm ok with continuing forward with the release.

LGTM! 😋

Copy link
Contributor

@rudyflores rudyflores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for making this PR Billie!

@JillieBeanSim
Copy link
Contributor Author

JillieBeanSim commented Dec 12, 2023

I have not found any showstoppers on the release. However, there is one small item that I haven't had a chance to thoroughly test. I'm referring to the addition of what seems to me like a new required method to the zowe-explorer-api package in the PR below:

That being said, I'm ok with continuing forward with the release.

LGTM! 😋

@zFernand0 I can push a ? for peace of mind before we go out 😄

@rudyflores
Copy link
Contributor

I have not found any showstoppers on the release. However, there is one small item that I haven't had a chance to thoroughly test. I'm referring to the addition of what seems to me like a new required method to the zowe-explorer-api package in the PR below:

That being said, I'm ok with continuing forward with the release.
LGTM! 😋

I can push a ? for peace of mind before we go out 😄

I tested with ftp extension and other extender and wasn't seeing issues when creating this PR, but I agree maybe extra piece of mind lol

@zFernand0 zFernand0 merged commit 2b64dd3 into main Dec 12, 2023
37 checks passed
@zFernand0 zFernand0 deleted the 2.13.0-release branch December 12, 2023 16:07
Copy link

Release succeeded for the main branch. 🎉

The following packages have been published:

Powered by Octorelease 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Add to PR's that don't require a CHANGELOG update released
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

4 participants