-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimize activation function #2611
Conversation
Signed-off-by: Rudy Flores <[email protected]>
Signed-off-by: Rudy Flores <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## next #2611 +/- ##
==========================================
- Coverage 92.91% 92.91% -0.01%
==========================================
Files 109 109
Lines 10083 10093 +10
Branches 2107 2110 +3
==========================================
+ Hits 9369 9378 +9
- Misses 713 714 +1
Partials 1 1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these changes @rudyflores! This is a nice approach to reducing activation time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks @rudyflores for this refactor
Proposed changes
Fixes #1985
Minimize Zowe Explorer
activate()
function to only run functions necessary forindirect
actions. That way Zowe Explorer will only complete full activation of thedirect
actions if Zowe Explorer is opened (clicking on the Zowe icon in the activity bar for example)What are direct/indirect actions in activation?
Indirect and Direct actions on Zowe Explorer is those that are used by extenders (indirect) and those that are used straight from the Zowe Explorer UI (direct).
Direct
tempPath
globals.defineGlobals
hideTempFolder
ProfilesUtils.initializeZoweTempFolder
SettingsConfig.standardizeSettings
globals.setActivated
Indirect
ZoweLogger.initializeZoweLogger
ZoweLocalStorage.initializeZoweLocalStorage
registerCredentialManager
ProfilesUtils.initializeZoweProfiles
Profiles.createInstance
PollDecorator.register
registerRefreshCommand
initializeSpoolProvider
TreeProviders.initializeProviders
registerCommonCommands
ZoweExplorerExtender.createInstance
watchConfigProfile
ZoweExplorerApiRegister.getInstance
Release Notes
Milestone: v3 Prereleases
Changelog: Minimized activation function in Zowe Explorer to load only certain actions when necessary
Types of changes
What types of changes does your code introduce to Zowe Explorer?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the revieweryarn workspace vscode-extension-for-zowe vscode:prepublish
has been executedFurther comments