Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[next] Merge from maintenance with 2.12.1 & 2.12.2 #2588

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

JillieBeanSim
Copy link
Contributor

@JillieBeanSim JillieBeanSim commented Nov 20, 2023

Proposed changes

Merge maintenance with 2.12.1 & 2.12.2

Release Notes

Milestone: n/a

Changelog: n/a

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found
  • I have added necessary documentation (if appropriate)
  • Any PR dependencies have been merged and published (if appropriate)

Further comments

@JillieBeanSim JillieBeanSim added the no-changelog Add to PR's that don't require a CHANGELOG update label Nov 20, 2023
@JillieBeanSim JillieBeanSim added this to the v3 pre-releases milestone Nov 20, 2023
@JillieBeanSim JillieBeanSim self-assigned this Nov 20, 2023
Copy link

sonarcloud bot commented Nov 20, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
22.4% 22.4% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (5f84872) 93.07% compared to head (ed2dc85) 92.95%.

Files Patch % Lines
packages/zowe-explorer/src/shared/actions.ts 24.00% 19 Missing ⚠️
...kages/zowe-explorer/src/dataset/ZoweDatasetNode.ts 80.00% 2 Missing ⚠️
packages/zowe-explorer/src/shared/utils.ts 90.47% 2 Missing ⚠️
packages/zowe-explorer/src/uss/actions.ts 93.10% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2588      +/-   ##
==========================================
- Coverage   93.07%   92.95%   -0.12%     
==========================================
  Files         108      108              
  Lines        9806     9898      +92     
  Branches     2028     2053      +25     
==========================================
+ Hits         9127     9201      +74     
- Misses        678      696      +18     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JillieBeanSim JillieBeanSim changed the title Merge maintenance with 2.12.1 & 2.12.2 [next] Merge maintenance with 2.12.1 & 2.12.2 Nov 20, 2023
@JillieBeanSim JillieBeanSim changed the title [next] Merge maintenance with 2.12.1 & 2.12.2 [next] Merge from maintenance with 2.12.1 & 2.12.2 Nov 20, 2023
@t1m0thyj t1m0thyj mentioned this pull request Nov 20, 2023
16 tasks
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

@traeok traeok merged commit 14b3734 into next Nov 21, 2023
28 of 31 checks passed
@traeok traeok deleted the merging/from-maintenance-2.12.x branch November 21, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Add to PR's that don't require a CHANGELOG update
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

4 participants