Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back interface for notfying extenders #2583

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

rudyflores
Copy link
Contributor

@rudyflores rudyflores commented Nov 17, 2023

Proposed changes

Added back the interface for notifying extenders onProfilesUpdate that seemed to have dissappeared after the ZoweExplorerApi.ts file was removed for v3 to a different file

Release Notes

Milestone: v3 pre-release 2

Changelog: Added back onProfilesUpdate interface lost from move to v3

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found
  • I have added necessary documentation (if appropriate)
  • Any PR dependencies have been merged and published (if appropriate)

Further comments

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8b4cfea) 93.05% compared to head (87fb3bc) 93.05%.
Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2583   +/-   ##
=======================================
  Coverage   93.05%   93.05%           
=======================================
  Files         108      108           
  Lines        9807     9807           
  Branches     2028     2028           
=======================================
  Hits         9126     9126           
  Misses        680      680           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Rudy Flores <[email protected]>
Copy link

sonarcloud bot commented Nov 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding back the api to the interface @rudyflores, this will help extenders begin the v3 adoption.
The changelog gh check failing even when a changelog item was added for repo can be addressed at later time for next branch

@likhithanimma1
Copy link
Contributor

Changes looks fine for me. Thankyou @rudyflores

@rudyflores rudyflores merged commit bad405c into next Nov 17, 2023
29 of 31 checks passed
@rudyflores rudyflores deleted the add-back-notification-for-extenders branch November 17, 2023 16:57
@JillieBeanSim JillieBeanSim mentioned this pull request Nov 17, 2023
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

3 participants