-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add back interface for notfying extenders #2583
Conversation
Signed-off-by: Rudy Flores <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2583 +/- ##
=======================================
Coverage 93.05% 93.05%
=======================================
Files 108 108
Lines 9807 9807
Branches 2028 2028
=======================================
Hits 9126 9126
Misses 680 680
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Rudy Flores <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding back the api to the interface @rudyflores, this will help extenders begin the v3 adoption.
The changelog gh check failing even when a changelog item was added for repo can be addressed at later time for next branch
Changes looks fine for me. Thankyou @rudyflores |
Proposed changes
Added back the interface for notifying extenders
onProfilesUpdate
that seemed to have dissappeared after theZoweExplorerApi.ts
file was removed for v3 to a different fileRelease Notes
Milestone: v3 pre-release 2
Changelog: Added back onProfilesUpdate interface lost from move to v3
Types of changes
What types of changes does your code introduce to Zowe Explorer?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the revieweryarn workspace vscode-extension-for-zowe vscode:prepublish
has been executedFurther comments