Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring 2.12.1 changes from maintenance into main #2559

Merged
merged 65 commits into from
Nov 13, 2023
Merged

Conversation

rudyflores
Copy link
Contributor

@rudyflores rudyflores commented Nov 9, 2023

Proposed changes

Bring in changes from maintenance branch into our main branch

Release Notes

Milestone: N/A

Changelog: N/A

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found
  • I have added necessary documentation (if appropriate)
  • Any PR dependencies have been merged and published (if appropriate)

Further comments

JillieBeanSim and others added 30 commits November 1, 2023 13:19
Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
Merging Main 2.12.0 updates and set patch release "2.12.1-SNAPSHOT"
Signed-off-by: Rudy Flores <[email protected]>
change shortcut to available shortcut keybind
Update when clause of Submit as JCL for when to show option
Signed-off-by: Rudy Flores <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
Move profile management menu items to proper location
@rudyflores rudyflores self-assigned this Nov 9, 2023
@rudyflores rudyflores added the no-changelog Add to PR's that don't require a CHANGELOG update label Nov 9, 2023
Copy link

sonarcloud bot commented Nov 9, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
23.3% 23.3% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Attention: 42 lines in your changes are missing coverage. Please review.

Files Coverage Δ
...ckages/zowe-explorer-api/src/tree/IZoweTreeNode.ts 100.00% <ø> (ø)
...ackages/zowe-explorer-api/src/vscode/ui/WebView.ts 96.66% <100.00%> (+0.11%) ⬆️
packages/zowe-explorer/src/PersistentFilters.ts 100.00% <100.00%> (ø)
packages/zowe-explorer/src/Profiles.ts 84.87% <100.00%> (+0.71%) ⬆️
...ges/zowe-explorer/src/command/MvsCommandHandler.ts 93.60% <100.00%> (ø)
...ges/zowe-explorer/src/command/TsoCommandHandler.ts 85.47% <100.00%> (ø)
packages/zowe-explorer/src/dataset/DatasetTree.ts 92.51% <100.00%> (+1.52%) ⬆️
packages/zowe-explorer/src/dataset/init.ts 100.00% <100.00%> (ø)
packages/zowe-explorer/src/extension.ts 100.00% <100.00%> (ø)
packages/zowe-explorer/src/globals.ts 98.65% <100.00%> (+0.04%) ⬆️
... and 17 more

📢 Thoughts on this report? Let us know!

traeok
traeok previously requested changes Nov 13, 2023
Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We added a similar fix in v2.12.1 for the USS tree, but I noticed that the logic for opening data sets also has the "path separation" issue. This could affect the way data sets are displayed in the editor for Windows users - I haven't tested this action extensively, but we might need a v2.12.2 to resolve this issue.

packages/zowe-explorer/src/dataset/actions.ts Show resolved Hide resolved
@JillieBeanSim JillieBeanSim dismissed traeok’s stale review November 13, 2023 18:58

will create new PR if another release goes out

Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks @rudyflores

@JillieBeanSim JillieBeanSim merged commit 30493eb into main Nov 13, 2023
34 of 35 checks passed
@JillieBeanSim JillieBeanSim deleted the 2.12.1-into-main branch November 13, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Add to PR's that don't require a CHANGELOG update
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

7 participants