fix(ds/sort): Fallback to sorting by name when values are equal

[traeok]

If we would prefer to keep this for a potential 2.12.1 release, then I will add a changelog. Otherwise, I think we can keep this as no-changelog as the feature will be released with 2.12.

---

Proposed changes

I've cleaned up the sorting function a bit so that it falls back to sorting by name when 2 node values are equal.

In addition, I've adjusted the date checks slightly to also use Day.js (consistent with the rest of the date processing for this feature) for easier date comparison.

Release Notes

Milestone: 2.12.0 (or 2.12.1)

Changelog:

• Fixed an issue where sorting functionality did not consider the sort direction when values were equal.

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

• Bugfix (non-breaking change which fixes an issue)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

• I have read the CONTRIBUTOR GUIDANCE wiki
• PR title follows Conventional Commits Guidelines
• PR Description is included
• gif or screenshot is included if visual changes are made
• yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
• All checks have passed (DCO, Jenkins and Code Coverage)
• I have added unit test and it is passing
• I have added integration test and it is passing
• There is coverage for the code that I have added
• I have tested it manually and there are no regressions found

[zFernand0]

Seems like this would work.
testing briefly before approving.

[adam-wolfe]

LGTM. Thanks Trae!

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Files	Coverage Δ
...kages/zowe-explorer/src/dataset/ZoweDatasetNode.ts	95.97% <100.00%> (+2.39%)	⬆️

... and 2 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

[adam-wolfe]

One minor issue I am seeing that may be related to this is that if a member has no user ID, and you sort by User ID in the descending order, the member without a user ID will switch to the top and bottom of the list when you collapse and expand the PDS.

[traeok]

One minor issue I am seeing that may be related to this is that if a member has no user ID, and you sort by User ID in the descending order, the member without a user ID will switch to the top and bottom of the list when you collapse and expand the PDS.

Thanks for catching this @adam-wolfe, I've addressed this in 9235f28

[adam-wolfe]

Looks good.

[traeok]

I found a separate, unrelated issue with how we were building children in ZoweDatasetNode - we were only checking for dsname as part of the "existing node" check, where we should fallback to look for the member variable when dsname isn't present. Otherwise, the check for an existing PDS member node will always yield undefined. See 2da3995 for the change that was made.

[zFernand0]

LGTM! 😋
Thanks for addressing the comments

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
2.6% Duplication