fix(cd): Workflow and Dependency Updates

[zFernand0]

Proposed changes

• Update workflows to run on LTS versions of Node.js
• Add OVSX CLI as a dev dependency
• Update overrides object to pnpm's format

Release Notes

Milestone: vNext

Changelog: Workflow and dependency updates

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

• I have read the CONTRIBUTOR GUIDANCE wiki
• PR title follows Conventional Commits Guidelines
• PR Description is included
• gif or screenshot is included if visual changes are made
• yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
• All checks have passed (DCO, Jenkins and Code Coverage)
• I have added unit test and it is passing
• I have added integration test and it is passing
• There is coverage for the code that I have added
• I have tested it manually and there are no regressions found
• I have added necessary documentation (if appropriate)
• Any PR dependencies have been merged and published (if appropriate)

Further comments

We never had the OVSX cli installed as a devDependency, it was just because of npx that this worked. In order to avoid undesired dependency version updates (with pnpm dlx), we use pnpm exec which won't download the latest version of the package from npm 😋

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9ad5a7f) 93.05% compared to head (f19d6b5) 93.05%.

Additional details and impacted files

@@           Coverage Diff           @@
##             next    #2529   +/-   ##
=======================================
  Coverage   93.05%   93.05%           
=======================================
  Files         108      108           
  Lines        9807     9807           
  Branches     2028     2028           
=======================================
  Hits         9126     9126           
  Misses        680      680           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[traeok]

I've been investigating the failing Theia tests on this PR and have found the source of the issue.

Commits ef72d44 and before work fine in Theia - localized strings show as expected.

When testing commit 3edd22f, the strings in Theia are broken. Any commit on next after this one exhibits the same behavior. This seems related to the package.json import statement in ZoweLocalStorage.ts.

Since this involves some refactoring of the local storage work, it would be best to address this in a separate PR. I will file a new issue to keep track of this.

Update: Created #2558 for this bug

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[JillieBeanSim]

LGTM! thanks @zFernand0 for this important fix and updates

[traeok]

LGTM! And thanks for updating the core VS Code dependencies @zFernand0 😋

[github-actions]

Release succeeded for the next branch. 🎉

The following packages have been published:

• npm: @zowe/[email protected]
• vsce: [email protected] (OVSX)
• vsce: [email protected] (OVSX)

_{Powered by Octorelease 🚀}