-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ds): Add descriptions to nodes when filter/sort is enabled #2521
Conversation
Signed-off-by: Trae Yelovich <[email protected]>
Codecov ReportAttention:
📢 Thoughts on this report? Let us know!. |
Signed-off-by: Trae Yelovich <[email protected]>
4166184
to
bd5dae3
Compare
Signed-off-by: Trae Yelovich <[email protected]>
801d0c9
to
ebd9a26
Compare
Signed-off-by: Trae Yelovich <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@traeok is this change all internal? Is there something we should see when testing?
@JillieBeanSim Sorry, I forgot to add a short description at the top of the PR. I just added a quick summary in the "Proposed changes" section of the visible differences:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @traeok this looks awesome!
Signed-off-by: Billie Simmons <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Proposed changes
This PR adds descriptions to nodes (either the session itself or the PDS that the sort/filter was applied to) to clarify sort/filter settings.
When sorting, if the sort option is set to date modified or user ID:
When filtering:
Release Notes
Milestone: 2.12.0 (or 2.13.0 if it doesn't make it into the release, not considered high priority)
Changelog:
Types of changes
What types of changes does your code introduce to Zowe Explorer?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the revieweryarn workspace vscode-extension-for-zowe vscode:prepublish
has been executed