Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ds): Add descriptions to nodes when filter/sort is enabled #2521

Merged
merged 6 commits into from
Oct 23, 2023

Conversation

traeok
Copy link
Member

@traeok traeok commented Oct 17, 2023

Proposed changes

This PR adds descriptions to nodes (either the session itself or the PDS that the sort/filter was applied to) to clarify sort/filter settings.

When sorting, if the sort option is set to date modified or user ID:

  • at session-level: all PDS members will show their value for this sort option to show how they are being sorted
  • at PDS-level: just the PDS members for a specific PDS will have these descriptions

image

When filtering:

  • at session-level: filter option shows beside session where it is applied
  • at PDS-level: filter option shows beside PDS where it is applied

image

Release Notes

Milestone: 2.12.0 (or 2.13.0 if it doesn't make it into the release, not considered high priority)

Changelog:

  • Added descriptions to data set nodes if filtering and/or sorting is enabled (where applicable).

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Files Coverage Δ
packages/zowe-explorer/src/dataset/DatasetTree.ts 92.39% <100.00%> (+0.55%) ⬆️
...kages/zowe-explorer/src/dataset/ZoweDatasetNode.ts 93.58% <85.71%> (+0.17%) ⬆️

📢 Thoughts on this report? Let us know!.

Signed-off-by: Trae Yelovich <[email protected]>
@traeok traeok changed the title feat(ds): Show descriptions for filter and sort values for clarity feat(ds): Add descriptions to nodes when filter/sort is enabled Oct 18, 2023
@traeok traeok marked this pull request as ready for review October 18, 2023 14:04
Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@traeok is this change all internal? Is there something we should see when testing?

@traeok
Copy link
Member Author

traeok commented Oct 20, 2023

@traeok is this change all internal? Is there something we should see when testing?

@JillieBeanSim Sorry, I forgot to add a short description at the top of the PR. I just added a quick summary in the "Proposed changes" section of the visible differences:

When sorting, if the sort option is set to date modified or user ID:

  • at session-level: all PDS members will show their value for this sort option, as a description beside the tree item
  • at PDS-level: just the PDS members for a specific PDS will have these descriptions

When filtering:

  • at session-level: filter option shows as description beside session where it is applied
  • at PDS-level: filter option shows as description beside PDS where it is applied

JillieBeanSim
JillieBeanSim previously approved these changes Oct 20, 2023
Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @traeok this looks awesome!

@sonarcloud
Copy link

sonarcloud bot commented Oct 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@zFernand0 zFernand0 merged commit 464d712 into main Oct 23, 2023
35 checks passed
@zFernand0 zFernand0 deleted the feat/ds/sort-enhancements branch October 23, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

4 participants