Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vNext] Merge maintenance with 2.9.2 work #2414

Merged
merged 116 commits into from
Aug 15, 2023
Merged

[vNext] Merge maintenance with 2.9.2 work #2414

merged 116 commits into from
Aug 15, 2023

Conversation

JillieBeanSim
Copy link
Contributor

@JillieBeanSim JillieBeanSim commented Aug 8, 2023

Proposed changes

Merge in released changes from 2.9.2 on maintenance branch

Release Notes

Milestone: vNext

Changelog: n/a

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found
  • I have added necessary documentation (if appropriate)
  • Any PR dependencies have been merged and published (if appropriate)

Further comments

JillieBeanSim and others added 30 commits June 14, 2023 14:23
Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Andrew W. Harn <[email protected]>
Signed-off-by: Andrew W. Harn <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
[maintenance] merge main and set "2.9.1-SNAPSHOT"
Signed-off-by: Rudy Flores <[email protected]>
Signed-off-by: Rudy Flores <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Fix watcher on browser based environments
@JillieBeanSim JillieBeanSim added the no-changelog Add to PR's that don't require a CHANGELOG update label Aug 8, 2023
@JillieBeanSim JillieBeanSim added this to the vNext milestone Aug 8, 2023
@JillieBeanSim JillieBeanSim self-assigned this Aug 8, 2023
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Patch coverage: 92.53% and project coverage change: +0.33% 🎉

Comparison is base (b0adef5) 92.05% compared to head (e5a6668) 92.38%.

❗ Current head e5a6668 differs from pull request most recent head d4c6eef. Consider uploading reports for the commit d4c6eef to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2414      +/-   ##
==========================================
+ Coverage   92.05%   92.38%   +0.33%     
==========================================
  Files          95       95              
  Lines        8745     8764      +19     
  Branches     1777     1781       +4     
==========================================
+ Hits         8050     8097      +47     
+ Misses        694      666      -28     
  Partials        1        1              
Files Changed Coverage Δ
...ges/zowe-explorer/src/abstract/ZoweTreeProvider.ts 88.53% <ø> (-0.08%) ⬇️
...kages/zowe-explorer/src/dataset/ZoweDatasetNode.ts 96.26% <82.60%> (+0.77%) ⬆️
packages/zowe-explorer/src/job/ZoweJobNode.ts 94.33% <86.95%> (+2.92%) ⬆️
packages/zowe-explorer/src/utils/ProfilesUtils.ts 90.26% <93.33%> (+0.41%) ⬆️
packages/zowe-explorer/src/dataset/DatasetTree.ts 91.12% <97.10%> (+3.14%) ⬆️
packages/zowe-explorer/src/job/ZosJobsProvider.ts 89.75% <100.00%> (-0.02%) ⬇️
packages/zowe-explorer/src/uss/USSTree.ts 92.87% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

zFernand0
zFernand0 previously approved these changes Aug 8, 2023
traeok
traeok previously approved these changes Aug 9, 2023
@t1m0thyj t1m0thyj dismissed stale reviews from traeok and zFernand0 via b2dde9d August 15, 2023 16:22
zFernand0
zFernand0 previously approved these changes Aug 15, 2023
traeok
traeok previously approved these changes Aug 15, 2023
Signed-off-by: Billie Simmons <[email protected]>
@t1m0thyj t1m0thyj dismissed stale reviews from traeok and zFernand0 via d4c6eef August 15, 2023 16:44
@sonarcloud
Copy link

sonarcloud bot commented Aug 15, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
12.4% 12.4% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@JillieBeanSim
Copy link
Contributor Author

Thanks @t1m0thyj for pushing that change

@t1m0thyj t1m0thyj merged commit fac50b5 into next Aug 15, 2023
23 of 25 checks passed
@t1m0thyj t1m0thyj deleted the merge-maintenance branch August 15, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Add to PR's that don't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants