Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yarn version to setup steps #2413

Merged
merged 3 commits into from
Aug 4, 2023
Merged

Add yarn version to setup steps #2413

merged 3 commits into from
Aug 4, 2023

Conversation

JillieBeanSim
Copy link
Contributor

@JillieBeanSim JillieBeanSim commented Aug 4, 2023

Proposed changes

Adding yarn version to top level README for dev setup

Release Notes

Milestone: n/a

Changelog: n/a

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found
  • I have added necessary documentation (if appropriate)
  • Any PR dependencies have been merged and published (if appropriate)

Further comments

Signed-off-by: Billie Simmons <[email protected]>
@JillieBeanSim JillieBeanSim added the no-changelog Add to PR's that don't require a CHANGELOG update label Aug 4, 2023
@JillieBeanSim JillieBeanSim self-assigned this Aug 4, 2023
Signed-off-by: Billie Simmons <[email protected]>
traeok

This comment was marked as outdated.

README.md Outdated
@@ -14,7 +14,7 @@ Join our [Slack channel](https://slack.openmainframeproject.org/) to connect wit
Client-side prerequisites for development:

- Install [Node.js](https://nodejs.org/en/download/) v14.0 or later.
- Install [Yarn](https://yarnpkg.com/getting-started/install).
- Install [Yarn](https://yarnpkg.com/getting-started/install) v1.22.19.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we should update the Yarn link to point to the classic Yarn subdomain since we are still using v1? That way users do not have to click on the classic banner at the top to get to v1 instructions.

Suggested change
- Install [Yarn](https://yarnpkg.com/getting-started/install) v1.22.19.
- Install [Yarn](https://classic.yarnpkg.com/en/docs/install) v1.22.19.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we say to install Yarn Classic? I don't think the exact version number matters - if Yarn releases a 1.22.20 patch, we'd likely support it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks all, changes pushed. feel free to push in updates to my PRs for Docs updates in the future 😉

Signed-off-by: Billie Simmons <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Aug 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JillieBeanSim!

@t1m0thyj t1m0thyj merged commit 776b987 into main Aug 4, 2023
10 checks passed
@t1m0thyj t1m0thyj deleted the update-dev-README branch August 4, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Add to PR's that don't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants