Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/check creds #2365

Closed
wants to merge 17 commits into from
Closed

Fix/check creds #2365

wants to merge 17 commits into from

Conversation

JillieBeanSim
Copy link
Contributor

@JillieBeanSim JillieBeanSim commented Jun 30, 2023

Proposed changes

WIP

Release Notes

Milestone: 2.9.2

Changelog:

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found
  • I have added necessary documentation (if appropriate)
  • Any PR dependencies have been merged and published (if appropriate)

Further comments

@JillieBeanSim JillieBeanSim self-assigned this Jun 30, 2023
@JillieBeanSim JillieBeanSim added this to the v2.9.2 milestone Jun 30, 2023
Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Patch coverage: 81.11% and project coverage change: +0.03 🎉

Comparison is base (ba1648d) 92.22% compared to head (7ece2fd) 92.26%.

Additional details and impacted files
@@               Coverage Diff               @@
##           maintenance    #2365      +/-   ##
===============================================
+ Coverage        92.22%   92.26%   +0.03%     
===============================================
  Files               91       91              
  Lines             9235     9239       +4     
  Branches          1917     1912       -5     
===============================================
+ Hits              8517     8524       +7     
+ Misses             717      714       -3     
  Partials             1        1              
Impacted Files Coverage Δ
...ges/zowe-explorer/src/abstract/ZoweTreeProvider.ts 88.53% <ø> (-0.08%) ⬇️
packages/zowe-explorer/src/dataset/DatasetTree.ts 88.19% <67.69%> (+0.18%) ⬆️
...kages/zowe-explorer/src/dataset/ZoweDatasetNode.ts 94.89% <78.57%> (-0.60%) ⬇️
packages/zowe-explorer/src/job/ZosJobsProvider.ts 91.19% <100.00%> (-0.02%) ⬇️
packages/zowe-explorer/src/uss/USSTree.ts 92.97% <100.00%> (+0.04%) ⬆️
packages/zowe-explorer/src/uss/ZoweUSSNode.ts 94.10% <100.00%> (-0.02%) ⬇️
packages/zowe-explorer/src/utils/ProfilesUtils.ts 91.79% <100.00%> (+1.79%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarcloud
Copy link

sonarcloud bot commented Jul 14, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

No Coverage information No Coverage information
18.4% 18.4% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@JillieBeanSim
Copy link
Contributor Author

closing in favor of #2382

@JillieBeanSim JillieBeanSim deleted the fix/check-creds branch September 8, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant