-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ds): Handle control characters in ds member names #2336
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## maintenance #2336 +/- ##
============================================
Coverage 92.29% 92.29%
============================================
Files 91 91
Lines 9237 9242 +5
Branches 1918 1922 +4
============================================
+ Hits 8525 8530 +5
Misses 711 711
Partials 1 1
☔ View full report in Codecov by Sentry. |
Hey @t1m0thyj, do we want to rebase this bugfix against maintenance? |
4217a16
to
fd8c33b
Compare
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
fd8c33b
to
b1ef08a
Compare
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed that when clicking on a "valid" member with special characters, this error appears:
Discussed in-person w/ @t1m0thyj; this might be due to a missing PTF on our test LPAR. Will update review once confirmed.
Signed-off-by: Timothy Johnson <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @t1m0thyj!
Proposed changes
Handles control characters in data set member names returned by the
List.allMembers
API.Depends on zowe/zowe-cli#1730
Release Notes
Milestone: 2.9.2
Changelog: Fixed error when listing data set members that include control characters in the name.
Types of changes
What types of changes does your code introduce to Zowe Explorer?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the revieweryarn workspace vscode-extension-for-zowe vscode:prepublish
has been executedFurther comments