Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ds): Handle control characters in ds member names #2336

Merged
merged 8 commits into from
Jul 25, 2023

Conversation

t1m0thyj
Copy link
Member

@t1m0thyj t1m0thyj commented Jun 12, 2023

Proposed changes

Handles control characters in data set member names returned by the List.allMembers API.

Depends on zowe/zowe-cli#1730

Release Notes

Milestone: 2.9.2

Changelog: Fixed error when listing data set members that include control characters in the name.

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found
  • I have added necessary documentation (if appropriate)
  • Any PR dependencies have been merged and published (if appropriate)

Further comments

@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (8a39f8d) 92.29% compared to head (40bedd5) 92.29%.

Additional details and impacted files
@@             Coverage Diff              @@
##           maintenance    #2336   +/-   ##
============================================
  Coverage        92.29%   92.29%           
============================================
  Files               91       91           
  Lines             9237     9242    +5     
  Branches          1918     1922    +4     
============================================
+ Hits              8525     8530    +5     
  Misses             711      711           
  Partials             1        1           
Impacted Files Coverage Δ
...kages/zowe-explorer/src/dataset/ZoweDatasetNode.ts 95.65% <100.00%> (+0.16%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zFernand0 zFernand0 self-requested a review June 13, 2023 15:13
@JillieBeanSim
Copy link
Contributor

Hey @t1m0thyj, do we want to rebase this bugfix against maintenance?

@t1m0thyj t1m0thyj force-pushed the fix/list-members-control-chars branch from 4217a16 to fd8c33b Compare June 30, 2023 13:09
@t1m0thyj t1m0thyj changed the base branch from main to maintenance June 30, 2023 13:09
@t1m0thyj t1m0thyj force-pushed the fix/list-members-control-chars branch from fd8c33b to b1ef08a Compare June 30, 2023 13:10
@t1m0thyj t1m0thyj added this to the v2.9.2 milestone Jul 14, 2023
@t1m0thyj t1m0thyj marked this pull request as ready for review July 14, 2023 17:58
Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed that when clicking on a "valid" member with special characters, this error appears:
error_dsmember_special_chars

Discussed in-person w/ @t1m0thyj; this might be due to a missing PTF on our test LPAR. Will update review once confirmed.

@sonarcloud
Copy link

sonarcloud bot commented Jul 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @t1m0thyj!

@zFernand0 zFernand0 merged commit 53eed46 into maintenance Jul 25, 2023
22 checks passed
@zFernand0 zFernand0 deleted the fix/list-members-control-chars branch July 25, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants