Skip to content

Commit

Permalink
Merge branch 'jobSubmitConfirm' of https://github.com/JasonIBM/vscode…
Browse files Browse the repository at this point in the history
…-extension-for-zowe into jobSubmitConfirm
  • Loading branch information
JasonIBM committed Nov 13, 2023
2 parents 535d1db + dbee2ab commit b7663b1
Show file tree
Hide file tree
Showing 23 changed files with 563 additions and 306 deletions.
2 changes: 2 additions & 0 deletions packages/eslint-plugin-zowe-explorer/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ All notable changes to the "eslint-plugin-zowe-explorer" package will be documen

### Bug fixes

## `2.12.1`

## `2.12.0`

## `2.11.2`
Expand Down
2 changes: 2 additions & 0 deletions packages/zowe-explorer-api/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ All notable changes to the "zowe-explorer-api" extension will be documented in t

### Bug fixes

## `2.12.1`

## `2.12.0`

### New features and enhancements
Expand Down
9 changes: 7 additions & 2 deletions packages/zowe-explorer-ftp-extension/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,19 @@ All notable changes to the "zowe-explorer-ftp-extension" extension will be docum

### Bug fixes

## `2.12.0`
## `2.12.1`

### Bug fixes

- Fixed ECONNRESET error when trying to upload or create an empty data set member. [#2350](https://github.com/zowe/vscode-extension-for-zowe/issues/2350)
- Fixed issue where temporary files for e-tag comparison were not deleted after use.
- Fixed issue where another connection attempt was made inside `putContents` (in `getContentsTag`) even though a connection was already active.

## `2.12.0`

### Bug fixes

- Fixed ECONNRESET error when trying to upload or create an empty data set member. [#2350](https://github.com/zowe/vscode-extension-for-zowe/issues/2350)

## `2.11.2`

### Bug fixes
Expand Down
12 changes: 12 additions & 0 deletions packages/zowe-explorer/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,18 @@ All notable changes to the "vscode-extension-for-zowe" extension will be documen

### Bug fixes

## `2.12.1`

### Bug fixes

- Fix issue with certain actions displaying profiles that are not registered with the tree that is providing the action. [#2534](https://github.com/zowe/vscode-extension-for-zowe/issues/2534)
- Update when the option to submit local file as JCL will be displayed in context menus. [#2541](https://github.com/zowe/vscode-extension-for-zowe/issues/2541)
- Solved issue with a conflicting keybinding for `Edit History`, changed keybinding to `Ctrl`+`Alt`+`y` for Windows and `⌘ Cmd`+`⌥ Opt`+`y` for macOS. [#2543](https://github.com/zowe/vscode-extension-for-zowe/issues/2543)
- Removed duplicate context menu items displayed in USS view that now exist within the `Manage Profile` option.[#2547](https://github.com/zowe/vscode-extension-for-zowe/issues/2547)
- Fixed issue where sort PDS feature applied the date description to members without a valid date [#2552](https://github.com/zowe/vscode-extension-for-zowe/issues/2552)
- Fixed VSC Compare function, not working with Favorites from Zowe Explorer. [#2549](https://github.com/zowe/vscode-extension-for-zowe/pull/2549)
- Fixed issue where setting `zowe.security.checkForCustomCredentialManagers` appeared in all scopes instead of just the user scope [#2555](https://github.com/zowe/vscode-extension-for-zowe/issues/2555)

## `2.12.0`

### New features and enhancements
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import { ZoweDatasetNode } from "../../../src/dataset/ZoweDatasetNode";
import { ZoweExplorerApiRegister } from "../../../src/ZoweExplorerApiRegister";
import * as globals from "../../../src/globals";
import { ZoweLogger } from "../../../src/utils/LoggerUtils";
import { ProfileManagement } from "../../../src/utils/ProfileManagement";

describe("mvsCommandActions unit testing", () => {
const showErrorMessage = jest.fn();
Expand Down Expand Up @@ -59,6 +60,10 @@ describe("mvsCommandActions unit testing", () => {
});
Object.defineProperty(ZoweLogger, "trace", { value: jest.fn(), configurable: true });
Object.defineProperty(ZoweLogger, "error", { value: jest.fn(), configurable: true });
Object.defineProperty(ProfileManagement, "getRegisteredProfileNameList", {
value: jest.fn().mockReturnValue(["firstName", "secondName"]),
configurable: true,
});

createQuickPick.mockReturnValue({
placeholder: 'Choose "Create new..." to define a new profile or select an existing profile to add to the Data Set Explorer',
Expand Down Expand Up @@ -404,25 +409,6 @@ describe("mvsCommandActions unit testing", () => {
expect(showInputBox.mock.calls.length).toBe(0);
});

it("tests the issueMvsCommand function no profiles error", async () => {
Object.defineProperty(profileLoader.Profiles, "getInstance", {
value: jest.fn(() => {
return {
allProfiles: [],
defaultProfile: undefined,
checkCurrentProfile: jest.fn(() => {
return profilesForValidation;
}),
validateProfiles: jest.fn(),
getBaseProfile: jest.fn(),
validProfile: ValidProfileEnum.VALID,
};
}),
});
await mvsActions.issueMvsCommand();
expect(showInformationMessage.mock.calls[0][0]).toEqual("No profiles available");
});

it("tests the issueMvsCommand prompt credentials", async () => {
Object.defineProperty(profileLoader.Profiles, "getInstance", {
value: jest.fn(() => {
Expand Down Expand Up @@ -626,4 +612,27 @@ describe("mvsCommandActions unit testing", () => {
expect(showErrorMessage.mock.calls.length).toBe(1);
expect(showErrorMessage.mock.calls[0][0]).toContain(testError.message);
});

it("tests the issueMvsCommand function no profiles error", async () => {
Object.defineProperty(profileLoader.Profiles, "getInstance", {
value: jest.fn(() => {
return {
allProfiles: [],
defaultProfile: undefined,
checkCurrentProfile: jest.fn(() => {
return profilesForValidation;
}),
validateProfiles: jest.fn(),
getBaseProfile: jest.fn(),
validProfile: ValidProfileEnum.VALID,
};
}),
});
Object.defineProperty(ProfileManagement, "getRegisteredProfileNameList", {
value: jest.fn().mockReturnValue([]),
configurable: true,
});
await mvsActions.issueMvsCommand();
expect(showInformationMessage.mock.calls[0][0]).toEqual("No profiles available");
});
});
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import * as utils from "../../../src/utils/ProfilesUtils";
import { imperative } from "@zowe/cli";
import { ZoweExplorerApiRegister } from "../../../src/ZoweExplorerApiRegister";
import { ZoweLogger } from "../../../src/utils/LoggerUtils";
import { ProfileManagement } from "../../../src/utils/ProfileManagement";

describe("mvsCommandActions unit testing", () => {
const showErrorMessage = jest.fn();
Expand Down Expand Up @@ -54,6 +55,10 @@ describe("mvsCommandActions unit testing", () => {
});
Object.defineProperty(ZoweLogger, "error", { value: jest.fn(), configurable: true });
Object.defineProperty(ZoweLogger, "trace", { value: jest.fn(), configurable: true });
Object.defineProperty(ProfileManagement, "getRegisteredProfileNameList", {
value: jest.fn().mockReturnValue(["firstName", "secondName"]),
configurable: true,
});

const ProgressLocation = jest.fn().mockImplementation(() => {
return {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import { ZoweDatasetNode } from "../../../src/dataset/ZoweDatasetNode";
import { ZoweExplorerApiRegister } from "../../../src/ZoweExplorerApiRegister";
import * as globals from "../../../src/globals";
import { ZoweLogger } from "../../../src/utils/LoggerUtils";
import { ProfileManagement } from "../../../src/utils/ProfileManagement";

describe("TsoCommandHandler unit testing", () => {
const showErrorMessage = jest.fn();
Expand Down Expand Up @@ -118,6 +119,10 @@ describe("TsoCommandHandler unit testing", () => {
Object.defineProperty(vscode.window, "createOutputChannel", { value: createOutputChannel });
Object.defineProperty(vscode, "ProgressLocation", { value: ProgressLocation });
Object.defineProperty(vscode.window, "withProgress", { value: withProgress });
Object.defineProperty(ProfileManagement, "getRegisteredProfileNameList", {
value: jest.fn().mockReturnValue(["firstName", "secondName"]),
configurable: true,
});

mockLoadNamedProfile.mockReturnValue({ profile: { name: "aProfile", type: "zosmf" } });
getConfiguration.mockReturnValue({
Expand Down Expand Up @@ -406,25 +411,6 @@ describe("TsoCommandHandler unit testing", () => {
expect(showInputBox.mock.calls.length).toBe(0);
});

it("tests the issueTsoCommand function no profiles error", async () => {
Object.defineProperty(profileLoader.Profiles, "getInstance", {
value: jest.fn(() => {
return {
allProfiles: [],
defaultProfile: undefined,
checkCurrentProfile: jest.fn(() => {
return profilesForValidation;
}),
validateProfiles: jest.fn(),
getBaseProfile: jest.fn(),
validProfile: ValidProfileEnum.VALID,
};
}),
});
await tsoActions.issueTsoCommand();
expect(showInformationMessage.mock.calls[0][0]).toEqual("No profiles available");
});

it("tests the issueTsoCommand prompt credentials", async () => {
Object.defineProperty(profileLoader.Profiles, "getInstance", {
value: jest.fn(() => {
Expand Down Expand Up @@ -645,4 +631,27 @@ describe("TsoCommandHandler unit testing", () => {
name: "test1",
});
});

it("tests the issueTsoCommand function no profiles error", async () => {
Object.defineProperty(profileLoader.Profiles, "getInstance", {
value: jest.fn(() => {
return {
allProfiles: [],
defaultProfile: undefined,
checkCurrentProfile: jest.fn(() => {
return profilesForValidation;
}),
validateProfiles: jest.fn(),
getBaseProfile: jest.fn(),
validProfile: ValidProfileEnum.VALID,
};
}),
});
Object.defineProperty(ProfileManagement, "getRegisteredProfileNameList", {
value: jest.fn().mockReturnValue([]),
configurable: true,
});
await tsoActions.issueTsoCommand();
expect(showInformationMessage.mock.calls[0][0]).toEqual("No profiles available");
});
});
Loading

0 comments on commit b7663b1

Please sign in to comment.