add more coverage and address unused imports

Signed-off-by: Billie Simmons <[email protected]>
zowe · Oct 9, 2023 · 91f8db1 · 91f8db1
1 parent b54abe3
commit 91f8db1
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 3 deletions.
diff --git a/packages/zowe-explorer/__tests__/__unit__/uss/ZoweUSSNode.unit.test.ts b/packages/zowe-explorer/__tests__/__unit__/uss/ZoweUSSNode.unit.test.ts
@@ -11,7 +11,6 @@
 
 import * as vscode from "vscode";
 import * as zowe from "@zowe/cli";
-import * as unixActions from "../../../src/uss/actions";
 import { Gui, ValidProfileEnum } from "@zowe/zowe-explorer-api";
 import { ZoweExplorerApiRegister } from "../../../src/ZoweExplorerApiRegister";
 import { Profiles } from "../../../src/Profiles";
@@ -32,7 +31,6 @@ import * as path from "path";
 import * as workspaceUtils from "../../../src/utils/workspace";
 import * as globals from "../../../src/globals";
 import * as ussUtils from "../../../src/uss/utils";
-import { ZoweLogger } from "../../../src/utils/LoggerUtils";
 import { ZoweLocalStorage } from "../../../src/utils/ZoweLocalStorage";
 import { LocalFileManagement } from "../../../src/utils/LocalFileManagement";
 jest.mock("fs");

diff --git a/packages/zowe-explorer/__tests__/__unit__/uss/actions.unit.test.ts b/packages/zowe-explorer/__tests__/__unit__/uss/actions.unit.test.ts
@@ -41,7 +41,6 @@ import { ZoweLocalStorage } from "../../../src/utils/ZoweLocalStorage";
 import * as wsUtils from "../../../src/utils/workspace";
 import * as context from "../../../src/shared/context";
 import { AttributeView } from "../../../src/uss/AttributeView";
-import { LocalFileManagement } from "../../../src/utils/LocalFileManagement";
 
 jest.mock("../../../src/utils/LoggerUtils");
 

diff --git a/packages/zowe-explorer/__tests__/__unit__/utils/LocalFileManagement.unit.test.ts b/packages/zowe-explorer/__tests__/__unit__/utils/LocalFileManagement.unit.test.ts
@@ -18,6 +18,7 @@ import * as unixActions from "../../../src/uss/actions";
 import * as dsActions from "../../../src/dataset/actions";
 import { LocalFileManagement } from "../../../src/utils/LocalFileManagement";
 import * as utils from "../../../src/shared/utils";
+import { ZoweLogger } from "../../../src/globals";
 
 jest.mock("fs");
 jest.mock("vscode");
@@ -77,5 +78,20 @@ describe("LocalFileManagement unit tests", () => {
             expect(mocks.mockDlUnixSpy).toBeCalledTimes(2);
             expect(mocks.mockDlDsSpy).not.toBeCalled();
         });
+        it("should log warning and return", async () => {
+            const mocks = createGlobalMocks();
+            mocks.mockFilesToCompare = [mocks.mockDsFileNode, mocks.mockDsFileNode];
+            Object.defineProperty(globals, "filesToCompare", { value: mocks.mockFilesToCompare, configurable: true });
+            mocks.mockIsDsNode = false;
+            Object.defineProperty(utils, "isZoweDatasetTreeNode", { value: jest.fn().mockReturnValue(mocks.mockIsDsNode), configurable: true });
+            mocks.mockIsUnixNode = false;
+            Object.defineProperty(utils, "isZoweUSSTreeNode", { value: jest.fn().mockReturnValue(mocks.mockIsUnixNode), configurable: true });
+            Object.defineProperty(ZoweLogger, "warn", { value: jest.fn(), configurable: true });
+            const logSpy = jest.spyOn(ZoweLogger, "warn");
+            await LocalFileManagement.compareChosenFileContent();
+            expect(mocks.mockDlUnixSpy).not.toBeCalled();
+            expect(mocks.mockDlDsSpy).not.toBeCalled();
+            expect(logSpy).toBeCalled();
+        });
     });
 });