Merge branch 'add-profile-4all-trees' of github.com:zowe/vscode-exten…

…sion-for-zowe into add-profile-4all-trees
zowe · Nov 30, 2023 · 758867b · 758867b
2 parents 3a04a7e + d76667c
commit 758867b
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/packages/zowe-explorer/CHANGELOG.md b/packages/zowe-explorer/CHANGELOG.md
@@ -13,6 +13,8 @@ All notable changes to the "vscode-extension-for-zowe" extension will be documen
 
 ### Bug fixes
 
+- Fixed dataset allocation issue when secondary space (or other numeric values that did not exists in the dataset-template) where specified [#2591](https://github.com/zowe/vscode-extension-for-zowe/issues/2591)
+
 ## `2.12.2`
 
 ### Bug fixes

diff --git a/packages/zowe-explorer/src/dataset/actions.ts b/packages/zowe-explorer/src/dataset/actions.ts
@@ -631,7 +631,7 @@ export async function createFile(node: api.IZoweDatasetTreeNode, datasetProvider
             if (property.key === `dsName`) {
                 dsName = property.value;
             } else {
-                if (typeof propertiesFromDsType[property.key] === "number") {
+                if (typeof propertiesFromDsType[property.key] === "number" || property.type === "number") {
                     dsPropsForAPI[property.key] = Number(property.value);
                 } else {
                     dsPropsForAPI[property.key] = property.value;

diff --git a/packages/zowe-explorer/src/globals.ts b/packages/zowe-explorer/src/globals.ts
@@ -146,12 +146,14 @@ export const DATA_SET_PROPERTIES = [
         key: `avgblk`,
         label: `Average Block Length`,
         value: null,
+        type: `number`,
         placeHolder: localize("createFile.attribute.avgblk", `Enter the average block length (if allocation unit = BLK)`),
     },
     {
         key: `blksize`,
         label: `Block Size`,
         value: null,
+        type: `number`,
         placeHolder: localize("createFile.attribute.blksize", `Enter a block size`),
     },
     {
@@ -170,6 +172,7 @@ export const DATA_SET_PROPERTIES = [
         key: `dirblk`,
         label: `Directory Blocks`,
         value: null,
+        type: `number`,
         placeHolder: localize("createFile.attribute.dirblk", `Enter the number of directory blocks`),
     },
     {
@@ -200,6 +203,7 @@ export const DATA_SET_PROPERTIES = [
         key: `primary`,
         label: `Primary Space`,
         value: null,
+        type: `number`,
         placeHolder: localize("createFile.attribute.primary", `Enter the primary space allocation`),
     },
     {
@@ -212,12 +216,14 @@ export const DATA_SET_PROPERTIES = [
         key: `lrecl`,
         label: `Record Length`,
         value: null,
+        type: `number`,
         placeHolder: localize("createFile.attribute.lrecl", `Enter the logical record length`),
     },
     {
         key: `secondary`,
         label: `Secondary Space`,
         value: null,
+        type: `number`,
         placeHolder: localize("createFile.attribute.secondary", `Enter the secondary space allocation`),
     },
     {