Skip to content

Commit

Permalink
address feedback
Browse files Browse the repository at this point in the history
Signed-off-by: Billie Simmons <[email protected]>
  • Loading branch information
JillieBeanSim committed Oct 6, 2023
1 parent 00af763 commit 742a90e
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,13 @@
"updateBasicAuthQpItem.updateCredentials.qpDetail": "Update stored username and password",
"deleteProfileQpItem.delete.qpLabel": "$(trash) Delete Profile",
"disableProfileValildationQpItem.disableValidation.qpLabel": "$(workspace-untrusted) Disable Profile Validation",
"disableProfileValildationQpItem.disableValidation.qpDetail": "Disable validation of server check for profile.",
"disableProfileValildationQpItem.disableValidation.qpDetail": "Disable validation of server check for profile",
"enableProfileValildationQpItem.enableValidation.qpLabel": "$(workspace-trusted) Enable Profile Validation",
"enableProfileValildationQpItem.enableValidation.qpDetail": "Enable validation of server check for profile.",
"enableProfileValildationQpItem.enableValidation.qpDetail": "Enable validation of server check for profile",
"editProfileQpItem.editProfile.qpLabel": "$(pencil) Edit Profile",
"editProfileQpItem.editProfile.qpDetail": "Update profile connection information",
"hideProfileQpItems.hideProfile.qpLabel": "$(eye-closed) Hide Profile",
"hideProfileQpItems.hideProfile.qpDetail": "Hide profile name from tree view.",
"hideProfileQpItems.hideProfile.qpDetail": "Hide profile name from tree view",
"loginQpItem.login.qpLabel": "$(arrow-right) Log in to authentication service",
"loginQpItem.login.qpDetail": "Log in to obtain a new token value",
"logoutQpItem.logout.qpLabel": "$(arrow-left) Log out of authentication service",
Expand Down
10 changes: 5 additions & 5 deletions packages/zowe-explorer/src/utils/ProfileManagement.ts
Original file line number Diff line number Diff line change
Expand Up @@ -81,13 +81,13 @@ export class ProfileManagement {
public static disableProfileValildationQpItem: Record<string, vscode.QuickPickItem> = {
[this.AuthQpLabels.disable]: {
label: localize("disableProfileValildationQpItem.disableValidation.qpLabel", "$(workspace-untrusted) Disable Profile Validation"),
description: localize("disableProfileValildationQpItem.disableValidation.qpDetail", "Disable validation of server check for profile."),
description: localize("disableProfileValildationQpItem.disableValidation.qpDetail", "Disable validation of server check for profile"),
},
};
public static enableProfileValildationQpItem: Record<string, vscode.QuickPickItem> = {
[this.AuthQpLabels.enable]: {
label: localize("enableProfileValildationQpItem.enableValidation.qpLabel", "$(workspace-trusted) Enable Profile Validation"),
description: localize("enableProfileValildationQpItem.enableValidation.qpDetail", "Enable validation of server check for profile."),
description: localize("enableProfileValildationQpItem.enableValidation.qpDetail", "Enable validation of server check for profile"),
},
};
public static editProfileQpItems: Record<string, vscode.QuickPickItem> = {
Expand All @@ -99,7 +99,7 @@ export class ProfileManagement {
public static hideProfileQpItems: Record<string, vscode.QuickPickItem> = {
[this.AuthQpLabels.hide]: {
label: localize("hideProfileQpItems.hideProfile.qpLabel", "$(eye-closed) Hide Profile"),
description: localize("hideProfileQpItems.hideProfile.qpDetail", "Hide profile name from tree view."),
description: localize("hideProfileQpItems.hideProfile.qpDetail", "Hide profile name from tree view"),
},
};
public static tokenAuthLoginQpItem: Record<string, vscode.QuickPickItem> = {
Expand Down Expand Up @@ -225,13 +225,13 @@ export class ProfileManagement {
return this.addFinalQpOptions(node, quickPickOptions);
}
private static addFinalQpOptions(node: IZoweTreeNode, quickPickOptions: vscode.QuickPickItem[]): vscode.QuickPickItem[] {
quickPickOptions.push(this.editProfileQpItems[this.AuthQpLabels.edit]);
quickPickOptions.push(this.hideProfileQpItems[this.AuthQpLabels.hide]);
if (node.contextValue.includes(globals.NO_VALIDATE_SUFFIX)) {
quickPickOptions.push(this.enableProfileValildationQpItem[this.AuthQpLabels.enable]);

Check warning on line 231 in packages/zowe-explorer/src/utils/ProfileManagement.ts

View check run for this annotation

Codecov / codecov/patch

packages/zowe-explorer/src/utils/ProfileManagement.ts#L231

Added line #L231 was not covered by tests
} else {
quickPickOptions.push(this.disableProfileValildationQpItem[this.AuthQpLabels.disable]);
}
quickPickOptions.push(this.editProfileQpItems[this.AuthQpLabels.edit]);
quickPickOptions.push(this.hideProfileQpItems[this.AuthQpLabels.hide]);
quickPickOptions.push(this.deleteProfileQpItem[this.AuthQpLabels.delete]);
return quickPickOptions;
}
Expand Down

0 comments on commit 742a90e

Please sign in to comment.