-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
copy pds into new target data set enhancement #2393
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Pujal <[email protected]>
packages/zosfiles/__tests__/__unit__/methods/copy/Copy.unit.test.ts
Dismissed
Show dismissed
Hide dismissed
packages/zosfiles/__tests__/__unit__/methods/copy/Copy.unit.test.ts
Dismissed
Show dismissed
Hide dismissed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2393 +/- ##
==========================================
- Coverage 91.32% 91.32% -0.01%
==========================================
Files 638 638
Lines 18210 18231 +21
Branches 3931 3942 +11
==========================================
+ Hits 16630 16649 +19
- Misses 1579 1580 +1
- Partials 1 2 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Pujal <[email protected]>
Signed-off-by: Pujal Gandhi <[email protected]>
Signed-off-by: Pujal <[email protected]>
Signed-off-by: Pujal <[email protected]>
Signed-off-by: Pujal <[email protected]>
Signed-off-by: Pujal <[email protected]>
Signed-off-by: Pujal <[email protected]>
Signed-off-by: Pujal <[email protected]>
Signed-off-by: Pujal Gandhi <[email protected]>
📅 Suggested merge-by date: 1/20/2025 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good, thanks @pujal0909! Left a few comments
packages/zosfiles/__tests__/__system__/methods/copy/Copy.system.test.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Pujal <[email protected]>
Signed-off-by: Pujal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the functionality and it LGTM 🙂
@pujal0909 Please add a system test for the case where target data set does not exist.
Question for @adam-wolfe and @anaxceron - should we update the help text for the zowe copy ds
command to explain that if the target data set does not exist, it will be created?
|
Signed-off-by: Pujal <[email protected]>
Signed-off-by: Pujal <[email protected]>
Signed-off-by: Pujal <[email protected]>
Signed-off-by: Pujal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a minor comment re: a changelog.
Signed-off-by: Pujal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality LGTM, thanks Pujal! I had couple small requests for changes and a follow-up question...
In the event where a user tries to copy to the same data set, can we return early from the command? Currently, if I try copying a PDS from source A.B.C
to the same destination (A.B.C
), the command copies each member, even though the source and destination are identical:
Signed-off-by: Pujal <[email protected]>
Signed-off-by: Pujal <[email protected]>
d342773
to
82135ec
Compare
Signed-off-by: Pujal <[email protected]>
Signed-off-by: Pujal <[email protected]>
Signed-off-by: Pujal <[email protected]>
Signed-off-by: Pujal <[email protected]>
Co-authored-by: Trae Yelovich <[email protected]> Signed-off-by: Timothy Johnson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @pujal0909!
Quality Gate passedIssues Measures |
What It Does
The enhancement creates a new PDS and copies the source members when a target PDS is inputted that does not exist. The response informs the user a new PDS has been created.
#2349
How to Test
Use the copy command with a target PDS that does not currently exist
zowe zos-files copy ds "existing-pds" "new-pds"
Review Checklist
I certify that I have:
Additional Comments