doc: Details on adding a Webpack external module for Imperative w/o Secrets SDK #2281
+32
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traeok
changed the title
require instead of await import for Secrets SDK
traeok
changed the title
require instead of await import for Secrets SDK
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2281 +/- ##
=======================================
Coverage 91.24% 91.24%
=======================================
Files 628 628
Lines 17867 17867
Branches 3735 3805 +70
=======================================
Hits 16302 16302
Misses 1564 1564
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Trae Yelovich <[email protected]>
traeok
force-pushed
the
fix/secrets-sdk-import
branch
from
620b9eb
to
0b3a57c
Compare
traeok
changed the title
traeok
requested review from
t1m0thyj,
gejohnston,
zFernand0,
awharn,
jace-roell,
ATorrise and
adam-wolfe
awharn
approved these changes
Oct 1, 2024
t1m0thyj
approved these changes
Oct 1, 2024
gejohnston
approved these changes
Oct 1, 2024
anaxceron
approved these changes
Oct 2, 2024
Signed-off-by: Trae Yelovich <[email protected]>
|
traeok
added
the
release-current
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What It Does
Formats the
EXTENDERS.mddocument for the Secrets SDKkeyringmodule, and adds information on how to add Secrets SDK to yourexternalssection of the Webpack config when needed (rare case).How to Test
Review Checklist
I certify that I have:
Additional Comments