Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3] Config profile set #2265

Merged
merged 16 commits into from
Oct 1, 2024
Merged

[v3] Config profile set #2265

merged 16 commits into from
Oct 1, 2024

Conversation

jace-roell
Copy link
Contributor

What It Does

  • Allows for specifying the profile to modify the secure value for using zowe config secure
  • Example: zowe config secure --profile "ssh" will result in only ssh secure values to be prompted for.

Review Checklist
I certify that I have:

Signed-off-by: jace-roell <[email protected]>
Signed-off-by: jace-roell <[email protected]>
Signed-off-by: jace-roell <[email protected]>
Signed-off-by: jace-roell <[email protected]>
Signed-off-by: jace-roell <[email protected]>
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.24%. Comparing base (4ead205) to head (ad95128).
Report is 17 commits behind head on master.

Files with missing lines Patch % Lines
...imperative/src/config/cmd/secure/secure.handler.ts 96.29% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2265   +/-   ##
=======================================
  Coverage   91.23%   91.24%           
=======================================
  Files         628      628           
  Lines       17858    17867    +9     
  Branches     3837     3840    +3     
=======================================
+ Hits        16293    16302    +9     
  Misses       1564     1564           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this! 🥳

One quick suggestion, I think we could reduce duplication of code in the test file 😋

Other than that... LGTM 😋

Signed-off-by: jace-roell <[email protected]>
@jace-roell jace-roell marked this pull request as ready for review September 18, 2024 14:24
Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this enhancement Jace! I can already see this being useful for testing secured credentials in a couple pipelines that we have 😁

I see that CodeQL spotted an unused import - will approve once addressed 😋

Signed-off-by: jace-roell <[email protected]>
@zFernand0 zFernand0 deleted the branch master September 19, 2024 15:50
@zFernand0 zFernand0 closed this Sep 19, 2024
@zFernand0 zFernand0 reopened this Sep 19, 2024
@zFernand0 zFernand0 changed the base branch from next to master September 19, 2024 15:51
jace-roell and others added 2 commits September 19, 2024 12:47
Copy link
Member

@gejohnston gejohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature. Just a minor re-wording request.

Signed-off-by: jace-roell <[email protected]>
Signed-off-by: jace-roell <[email protected]>
Copy link
Contributor

@anaxceron anaxceron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one small note. Otherwise, looks good. Thank you @jace-roell!

packages/imperative/CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: jace-roell <[email protected]>
@zFernand0 zFernand0 linked an issue Sep 23, 2024 that may be closed by this pull request
Copy link

sonarcloud bot commented Sep 27, 2024

@t1m0thyj t1m0thyj merged commit b11995e into master Oct 1, 2024
17 checks passed
@t1m0thyj t1m0thyj deleted the configProfileSet branch October 1, 2024 13:25
@t1m0thyj t1m0thyj added the release-current Indicates that there is no new functionality being delivered label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-current Indicates that there is no new functionality being delivered
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

Add --profile-path profiles.base option to config secure
7 participants