-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v3] Config profile set #2265
[v3] Config profile set #2265
Conversation
Signed-off-by: jace-roell <[email protected]>
Signed-off-by: jace-roell <[email protected]>
Signed-off-by: jace-roell <[email protected]>
Signed-off-by: jace-roell <[email protected]>
Signed-off-by: jace-roell <[email protected]>
Signed-off-by: jace-roell <[email protected]>
packages/imperative/src/imperative/src/config/cmd/secure/secure.handler.ts
Fixed
Show fixed
Hide fixed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2265 +/- ##
=======================================
Coverage 91.23% 91.24%
=======================================
Files 628 628
Lines 17858 17867 +9
Branches 3837 3840 +3
=======================================
+ Hits 16293 16302 +9
Misses 1564 1564
Partials 1 1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this! 🥳
One quick suggestion, I think we could reduce duplication of code in the test file 😋
Other than that... LGTM 😋
Signed-off-by: jace-roell <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for this enhancement Jace! I can already see this being useful for testing secured credentials in a couple pipelines that we have 😁
I see that CodeQL spotted an unused import - will approve once addressed 😋
Signed-off-by: jace-roell <[email protected]>
Signed-off-by: jace-roell <[email protected]>
Signed-off-by: Jace Roell <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice feature. Just a minor re-wording request.
packages/imperative/src/imperative/src/config/cmd/secure/secure.definition.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: jace-roell <[email protected]>
Signed-off-by: jace-roell <[email protected]>
Signed-off-by: Jace Roell <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one small note. Otherwise, looks good. Thank you @jace-roell!
Signed-off-by: jace-roell <[email protected]>
Signed-off-by: Jace Roell <[email protected]>
Quality Gate passedIssues Measures |
What It Does
zowe config secure
zowe config secure --profile "ssh"
will result in onlyssh
secure values to be prompted for.Review Checklist
I certify that I have: