Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3] Rename Proxy class to ProxySettings #2238

Merged
merged 3 commits into from
Aug 23, 2024
Merged

Conversation

t1m0thyj
Copy link
Member

What It Does

Resolves #2230

How to Test

Review Checklist
I certify that I have:

Additional Comments

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.22%. Comparing base (1de341e) to head (d929652).
Report is 6 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff            @@
##             next    #2238    +/-   ##
========================================
  Coverage   91.22%   91.22%            
========================================
  Files         632      632            
  Lines       18142    18142            
  Branches     3887     3779   -108     
========================================
  Hits        16550    16550            
  Misses       1591     1591            
  Partials        1        1            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, thanks Timothy!

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

@zFernand0 zFernand0 requested a review from janan07 August 21, 2024 20:51
@t1m0thyj t1m0thyj linked an issue Aug 22, 2024 that may be closed by this pull request
Copy link

@janan07 janan07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed by doc squad

Copy link

sonarcloud bot commented Aug 23, 2024

@t1m0thyj t1m0thyj merged commit 6f67d4b into next Aug 23, 2024
18 of 19 checks passed
@t1m0thyj t1m0thyj deleted the v3/rename-proxy-class branch August 23, 2024 17:59
@t1m0thyj t1m0thyj mentioned this pull request Aug 23, 2024
4 tasks
Copy link

Release succeeded for the next branch. 🎉

The following packages have been published:

Powered by Octorelease 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

Proxy class may conflict with JS built-in object
5 participants