Fix Yargs parsing strings as numbers

[awharn]

What It Does

Prevents parsing string arguments as numbers if the value provided only consists of numerics.
Resolves #1881

How to Test

Run the zowe files download ds "FAKE.DS" --rto 50 --encoding 1047 --show-inputs-only command and observe the response timeout is blue (number) and encoding is white (string).

Review Checklist
I certify that I have:

• tested my changes
• added/updated automated tests
• updated the changelog
• followed the contribution guidelines

Additional Comments

[awharn]

The reason we took this approach was because of a regression observed if we passed numbers to Yargs as number typed options. If a user supplied an option that took a number and provided no value i.e zowe files list ds "FAKE.DS" --rto --encoding 939, the handler validation would completely ignore the specified numeric option with no value.

That is because yargs returns undefined for number options specified with no value, but returns "" for string options specified with no value. Therefore, our validation can't detect the missing value when it is a number, since it is the same as if it wasn't specified at all.

This behavior would be a regression with no easy fix. In this implementation, we continue to treat numerics as a string until validation is done to confirm the option was not specified with an empty value (""), and the value provided is numeric. Once that validation is completed, the value of the argument is converted from string to number.

Because we disabled the default yargs behavior to convert strings to numbers, we explicitly do the conversion when the option type is a number. Otherwise, it remains a string.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.22%. Comparing base (237513b) to head (1de341e).
Report is 9 commits behind head on next.

Additional details and impacted files

@@            Coverage Diff             @@
##             next    #2237      +/-   ##
==========================================
+ Coverage   91.20%   91.22%   +0.01%     
==========================================
  Files         632      632              
  Lines       18134    18142       +8     
  Branches     3848     3887      +39     
==========================================
+ Hits        16540    16550      +10     
+ Misses       1593     1591       -2     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[adam-wolfe]

Looks good, but is it safe for us to assume that all numeric values will be integers?

[t1m0thyj]

LGTM, thanks @awharn!

[traeok]

LGTM, thanks @awharn for the fix!

[adam-wolfe]

LGTM, thanks @awharn

[awharn]

Found a small bug - the change was not converting the values assigned to the alternate option names (aliases and camel case) to numbers, which caused system tests to fail for creating data-sets. Regression tests added, and changed the implementation to use the CliUtils.setOptionValue function to set all options, camel and kebab case options, aliases, and camel and kebab case aliases to the same (number) value.

Re-requested reviews from all reviewers.

[t1m0thyj]

LGTM, thanks @awharn for updating this to handle aliases too! 😋

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
96.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[zFernand0]

Changes LGTM! 😋