[v2] ssh keypassphrase port from v3 #2232
Conversation
Signed-off-by: jace-roell <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2232 +/- ##
==========================================
+ Coverage 91.15% 91.24% +0.09%
==========================================
Files 638 638
Lines 19102 19142 +40
Branches 3926 3941 +15
==========================================
+ Hits 17413 17467 +54
+ Misses 1688 1674 -14
Partials 1 1 ☔ View full report in Codecov by Sentry. |
jace-roell
requested review from
t1m0thyj,
gejohnston,
zFernand0,
awharn,
traeok,
anaxceron,
ATorrise and
adam-wolfe
There was a problem hiding this comment.
Looks pretty good, thanks for porting the changes @jace-roell! Left a few comments
Signed-off-by: jace-roell <[email protected]>
Signed-off-by: jace-roell <[email protected]>
packages/imperative/src/rest/src/session/ConnectionPropsForSessCfg.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: jace-roell <[email protected]>
There was a problem hiding this comment.
According to Zowe docs, the order of precedence for SSH commands is SSH key, then user & password:
When testing this PR locally if I've stored values for user and password in my base profile, and have an SSH profile that defines privateKey and contains keyPassphrase in the secure array, then I get prompted for a value for keyPassphrase as expected. But if I remove user and password from my base profile and leave keyPassphrase, then issue an SSH command, I am prompted for user and password which should not be needed.
I see the same behavior in Zowe V3, so not sure if this is actually an issue, and if so whether we want to handle it separately outside of this PR? 😋
There was a problem hiding this comment.
LGTM, thanks @jace-roell!
Sorry for the false alarm - after further discussion realized that the command behaves as expected, and my test environment was tainted by a global config file.
|
awharn
added
the
release-current
What It Does
Resolved bug that resulted in user not being prompted for a key passphrase if it is located in the secure credential array of the ssh profile. (port from v3)
Review Checklist
I certify that I have: