Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Next with Master Changes #2228

Merged
merged 23 commits into from
Aug 13, 2024
Merged

Update Next with Master Changes #2228

merged 23 commits into from
Aug 13, 2024

Conversation

awharn
Copy link
Member

@awharn awharn commented Aug 9, 2024

What It Does

Updates next with recent changes on master that resolve additional deprecations and file conflicts.
Fixes a situation where running tests locally on MacOS results in broken tests due to keychain operations.

How to Test

Review Checklist
I certify that I have:

Additional Comments

awharn and others added 21 commits August 6, 2024 10:14
Signed-off-by: Andrew W. Harn <[email protected]>
Signed-off-by: Andrew W. Harn <[email protected]>
Signed-off-by: Andrew W. Harn <[email protected]>
Signed-off-by: Andrew W. Harn <[email protected]>
Signed-off-by: Andrew W. Harn <[email protected]>
Signed-off-by: Andrew W. Harn <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Andrew W. Harn <[email protected]>
Signed-off-by: Andrew W. Harn <[email protected]>
Signed-off-by: Andrew W. Harn <[email protected]>
Use Fewer Deprecated Functions in Master
Fix error using session with auth type "none"
Signed-off-by: Andrew W. Harn <[email protected]>
Signed-off-by: Andrew W. Harn <[email protected]>
Signed-off-by: Andrew W. Harn <[email protected]>
Signed-off-by: Andrew W. Harn <[email protected]>
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.20%. Comparing base (ff16d35) to head (72668a1).
Report is 2 commits behind head on next.

Files Patch % Lines
...li/src/zosconsole/issue/command/Command.handler.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2228   +/-   ##
=======================================
  Coverage   91.20%   91.20%           
=======================================
  Files         632      632           
  Lines       18128    18128           
  Branches     3780     3849   +69     
=======================================
  Hits        16534    16534           
  Misses       1593     1593           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @awharn for updating integration tests to run more stable on MacOS and porting my PR #2218 😋

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Andrew

Copy link

sonarcloud bot commented Aug 12, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
58.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@awharn awharn merged commit 55204b0 into next Aug 13, 2024
47 of 48 checks passed
@awharn awharn deleted the update-next-with-master branch August 13, 2024 13:53
Copy link

Release succeeded for the next branch. 🎉

The following packages have been published:

Powered by Octorelease 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

5 participants