Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] allow showMsgWhenDeprecated to accept an empty string as a parameter … #2226

Merged
merged 18 commits into from
Aug 13, 2024

Conversation

jace-roell
Copy link
Contributor

@jace-roell jace-roell commented Aug 9, 2024

What It Does
Modified showMsgWhenDeprecated() to allow an empty string as a paramter when no replacement is availible for deprecated command to print an alternative message.

Review Checklist
I certify that I have:

…to show an alternative error message

Signed-off-by: jace-roell <[email protected]>
@jace-roell jace-roell linked an issue Aug 9, 2024 that may be closed by this pull request
Signed-off-by: jace-roell <[email protected]>
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.24%. Comparing base (2f977b7) to head (bd8ceec).
Report is 1 commits behind head on master.

Files Patch % Lines
...mperative/src/cmd/src/help/DefaultHelpGenerator.ts 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2226      +/-   ##
==========================================
- Coverage   91.24%   91.24%   -0.01%     
==========================================
  Files         638      638              
  Lines       19142    19146       +4     
  Branches     3989     4057      +68     
==========================================
+ Hits        17467    17470       +3     
- Misses       1674     1675       +1     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jace-roell jace-roell marked this pull request as ready for review August 12, 2024 18:09
Copy link
Contributor

@anaxceron anaxceron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested a few edits - thank you!

packages/imperative/CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: jace-roell <[email protected]>
Copy link
Contributor

@anaxceron anaxceron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good -- thanks @jace-roell!

Signed-off-by: jace-roell <[email protected]>
Signed-off-by: jace-roell <[email protected]>
Copy link
Member

@awharn awharn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jace-roell! Sorry for all the change requests. 🚀

@awharn
Copy link
Member

awharn commented Aug 13, 2024

It looks like the automation did something it shouldn't have done. It seems to have updated the change log to replace Recent Changes with the current versionc(7.28.4). When you update, can you remove the latest version on the Changelog and put it back under the Recent Changes header? We will need to update OctoRelease to not do this.

Signed-off-by: jace-roell <[email protected]>
Copy link

sonarcloud bot commented Aug 13, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
77.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@awharn awharn merged commit 596b44e into master Aug 13, 2024
18 of 19 checks passed
@awharn awharn deleted the deprecated-commands-function branch August 13, 2024 19:54
@awharn awharn added the release-minor Indicates a minor feature has been added label Aug 13, 2024
Copy link

Release succeeded for the master branch. 🎉

The following packages have been published:

Powered by Octorelease 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-minor Indicates a minor feature has been added released
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

Deprecation of Commands Requires Replacement Command
6 participants