Fix Secrets SDK CI to work with MacOS ARM runners #2155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timothy Johnson <[email protected]>
t1m0thyj
requested review from
gejohnston,
zFernand0,
awharn,
traeok and
ATorrise
traeok
approved these changes
May 24, 2024
Comment on lines
-71
to
-76
| sudo rm -Rf /Library/Developer/CommandLineTools/SDKs/*; | ||
| export CC=$(xcrun -f clang); | ||
| export CXX=$(xcrun -f clang++); | ||
| SYSROOT=$(xcrun --sdk macosx --show-sdk-path); | ||
| export CFLAGS="-isysroot $SYSROOT -isystem $SYSROOT"; | ||
| npm run build -- --target aarch64-apple-darwin |
There was a problem hiding this comment.
Its not convenient that the pipeline broke, but at least we were able to remove these steps from the aarch64 build 😋
Signed-off-by: Timothy Johnson <[email protected]>
ATorrise
approved these changes
May 24, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2155 +/- ##
=======================================
Coverage 91.21% 91.21%
=======================================
Files 628 628
Lines 17891 17891
Branches 3755 3792 +37
=======================================
Hits 16319 16319
Misses 1571 1571
Partials 1 1 ☔ View full report in Codecov by Sentry. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What It Does
Applies changes from napi-rs/package-template@299e2a6 so that x64 and ARM binaries for MacOS are built correctly now that
macos-latestrunner defaults to ARM architectureHow to Test
Review Checklist
I certify that I have:
Additional Comments