-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore precedence of token over password in AbstractRestClient - V3 #2125
Conversation
Signed-off-by: Gene Johnston <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #2125 +/- ##
==========================================
+ Coverage 90.98% 91.05% +0.07%
==========================================
Files 618 618
Lines 17484 17515 +31
Branches 3605 3617 +12
==========================================
+ Hits 15907 15948 +41
+ Misses 1576 1566 -10
Partials 1 1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look identical to the other PR. 🥳
LGTM! 😋
Left a small question in case we wanted to reverse the order in the array to Basic > Token
(for consistency with other implementations) 😋
SessConstants.AUTH_TYPE_TOKEN, | ||
SessConstants.AUTH_TYPE_BASIC, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to reverse the order here (basic > Token) since this is against the next
branch (to be consistent)?
or keep it as is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even though we are "allowed" to make breaking changes in V3, I think that the same extenders will hit the same dead-end failure with no practical solution. Their products will be broken.
I think that we will have to keep the current credential order in place until we implement a means for extenders (and maybe end-users) to specify their preferred order of credentials. I don't think that we know when we will undertake such an enhancement. I also cannot predict if that enhancement can be done in a non-breaking fashion after V3 is released. None-the-less, I think we have to stick with the current order for now.
Signed-off-by: Gene Johnston <[email protected]>
Quality Gate passedIssues Measures |
Release succeeded for the The following packages have been published:
Powered by Octorelease 🚀 |
What It Does
Implements the same changes into V3 as the following pull request did in V2:
Reinstate token precedence over password in AbstractRestClient #2119
Related issue : Breaking Change in User/Password/Token Order of Precedence #2109 (already closed)
How to Test
Review Checklist
I certify that I have:
Additional Comments