Fix api for uploading buffer to uss file #2089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timothy Johnson <[email protected]>
t1m0thyj
requested review from
ATorrise,
awharn,
gejohnston,
zFernand0 and
traeok
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2089 +/- ##
=======================================
Coverage 90.93% 90.93%
=======================================
Files 616 616
Lines 17377 17386 +9
Branches 3676 3579 -97
=======================================
+ Hits 15801 15810 +9
Misses 1575 1575
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Timothy Johnson <[email protected]>
awharn
approved these changes
Mar 13, 2024
|
Remember to update the breaking change document with the renamed input. :) |
|
gejohnston
approved these changes
Mar 13, 2024
| @@ -2,6 +2,11 @@ | |||
|
|
|||
| All notable changes to the Zowe z/OS files SDK package will be documented in this file. | |||
|
|
|||
| ## Recent Changes | |||
|
|
|||
| - LTS Breaking: Changed return type of `Upload.bufferToUssFile` to return `IZosFilesResponse` object instead of string. [#2089](https://github.com/zowe/zowe-cli/pull/2089) | |||
There was a problem hiding this comment.
Although it is not related to this pull request itself, you should update the V3 breaking changes document with this item.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What It Does
Upload.bufferToUssFileto returnIZosFilesResponseobject instead of stringUpload.bufferToUssFilenot normalizing new lines when uploading plain textHow to Test
Zowe CLI doesn't call this API so no easy way to test it there. However we should be able to test it in FileSystemProvider PR for Zowe Explorer 😋 zowe/zowe-explorer-vscode#2777
Review Checklist
I certify that I have:
Additional Comments