Ssh error

[ATorrise]

What It Does
Fixes #1031 :

• enables addition of user/password to ssh profile (which will never support apiml) when apimltoken is present in base
• provides better error message for debugging connectivity to plugins. not possible to be precise as plugins manage themselves differently and it will not always be clear why connectivity is unsuccessful. Failure could be due to any of the 3 options when an apiml token is present:
  • service failure
  • apiml is not supported by that plugin (not easy for us to programatically discern)
  • invalid/expired credentials or properties

How to Test

• For vscode launch.json

    {
        "type": "node",
        "request": "launch",
        "name": "ssh error",
        "program": "${workspaceFolder}/zowe-cli/packages/cli/lib/main.js",
        "console": "integratedTerminal",
        "args": ["zos-uss", "issue", "ssh", "echo test"],
        "outputCapture": "std",
        "resolveSourceMapLocations": null
    },

• Regular command:
  zowe zos-uss issue ssh "echo test"

Review Checklist
I certify that I have:

• tested my changes
• added/updated automated tests
• updated the changelog
• followed the contribution guidelines

Additional Comments
Handling connectivity errors with other plugins that aren't yet supported by apiml should be a topic for discussion amongst team (ie: CICS and MQ)

Result of PR:

New error handling for other plugins apiml doesn't support AND that have yet to implement supportedAuthTypes?: AUTH_TYPE_CHOICES[]

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.93%. Comparing base (4e08fa7) to head (777a558).

Additional details and impacted files

@@            Coverage Diff             @@
##             next    #2081      +/-   ##
==========================================
- Coverage   90.94%   90.93%   -0.01%     
==========================================
  Files         616      616              
  Lines       17386    17393       +7     
  Branches     3621     3586      -35     
==========================================
+ Hits        15811    15817       +6     
- Misses       1574     1575       +1     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[t1m0thyj]

To fix #1031 I'm not sure that the error message needs to be changed. I believe for SSH commands we wanted to prompt for user/password if they are missing instead of showing the error (since SSH doesn't support token authentication).

requested changes for errors/prompting have been addressed

[awharn]

Just one small comment up for discussion. This implementation looks great! 🚀

[t1m0thyj]

LGTM, thanks @ATorrise!

[zFernand0]

LGTM! 😋
left a small comment re: Andrew's idea 😋

[zFernand0]

thanks for addressing the comment so quickly! 🥳
LGTM! 😋

[sonarcloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
92.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[github-actions]

Release succeeded for the next branch. 🎉

The following packages have been published:

• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]

_{Powered by Octorelease 🚀}