Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for --help-examples #2064

Merged
merged 3 commits into from
Feb 23, 2024
Merged

Fixes for --help-examples #2064

merged 3 commits into from
Feb 23, 2024

Conversation

KevinLoesch1
Copy link
Contributor

@KevinLoesch1 KevinLoesch1 commented Feb 23, 2024

What It Does
This fix corrects several commands where the --help-examples fails to include the group in the example. This pull request will fix issues #1715 and #1865.

How to Test
Issue the --help-examples command at the group level. It should now display the group properly. For example, zowe zos-jobs --help-examples should display the group and command in the examples.

`

Submit the JCL in the USS file "/a/ibmuser/compile.jcl":

  $ zowe zos-jobs submit uss-file "/a/ibmuser/compile.jcl"

`

Review Checklist
I certify that I have:

Signed-off-by: KevinLoesch1 <[email protected]>
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.07%. Comparing base (e2a25ee) to head (7825c64).

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2064      +/-   ##
==========================================
- Coverage   91.08%   91.07%   -0.01%     
==========================================
  Files         638      638              
  Lines       18825    18828       +3     
  Branches     3920     3811     -109     
==========================================
+ Hits        17147    17148       +1     
- Misses       1677     1679       +2     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: KevinLoesch1 <[email protected]>
Copy link
Member

@gejohnston gejohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice contribution on your last day in our team.

Copy link
Contributor

@adam-wolfe adam-wolfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @KevinLoesch1

Copy link

sonarcloud bot commented Feb 23, 2024

@KevinLoesch1 KevinLoesch1 merged commit 5d71e2f into next Feb 23, 2024
28 of 29 checks passed
@KevinLoesch1 KevinLoesch1 deleted the fix-for-help-examples branch February 23, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

3 participants