Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent SDK pinning in V3 and Merge Master into Next #1975

Merged
merged 30 commits into from
Nov 28, 2023

Conversation

awharn
Copy link
Member

@awharn awharn commented Nov 28, 2023

What It Does
Unpins the dependencies for all SDKs, requiring only the same major version, addressing #1968
Plug-ins are required to lock down their own dependencies.

Also catches next branch back up to master.

How to Test

Review Checklist
I certify that I have:

Additional Comments

traeok and others added 28 commits October 30, 2023 16:01
added info re: Zowe project structure and governance

Signed-off-by: anaxceron <[email protected]>
Adding capitalization to Structure and Governance headers

Signed-off-by: anaxceron <[email protected]>
Signed-off-by: Gene Johnston <[email protected]>
feat(secrets): Core crate to expose Rust modules as library
Deprecate getZoweYargsResponse
Update flagged code since prefix should never be null
Signed-off-by: Andrew W. Harn <[email protected]>
Signed-off-by: Andrew W. Harn <[email protected]>
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d317aae) 91.03% compared to head (4d8999e) 91.03%.
Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #1975   +/-   ##
=======================================
  Coverage   91.03%   91.03%           
=======================================
  Files         635      635           
  Lines       18613    18613           
  Branches     3861     3861           
=======================================
  Hits        16944    16944           
  Misses       1668     1668           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@gejohnston gejohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only saw a minor typo. Supplied a separate comment for it.

README.md Outdated Show resolved Hide resolved
Signed-off-by: Andrew W. Harn <[email protected]>
@zFernand0 zFernand0 mentioned this pull request Nov 28, 2023
4 tasks
@zFernand0
Copy link
Member

Seems like we never added a changelog to the secrets SDK when we exported secrets_core ?

@awharn
Copy link
Member Author

awharn commented Nov 28, 2023

@zFernand0 That is correct, we did not add a changelog entry for that. It was a behind the scenes change in the Rust library and didn't result in any notable changes to the secrets SDK itself.

Copy link

sonarcloud bot commented Nov 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@zFernand0 zFernand0 merged commit 797598a into next Nov 28, 2023
21 of 22 checks passed
@zFernand0 zFernand0 deleted the prevent-sdk-pinning branch November 28, 2023 19:31
@zFernand0 zFernand0 added the release-current Indicates that there is no new functionality being delivered label Nov 28, 2023
Copy link

Release succeeded for the next branch. 🎉

The following packages have been published:

Powered by Octorelease 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-current Indicates that there is no new functionality being delivered released
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

8 participants