Merge pull request #2277 from zowe/fix/secrets-sdk-requirement

Remove Secrets SDK requirement when Imperative is a bundled dep
zowe · Sep 26, 2024 · 4e14312 · 4e14312
2 parents 606d579 + 77dda1b
commit 4e14312
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/packages/imperative/CHANGELOG.md b/packages/imperative/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 All notable changes to the Imperative package will be documented in this file.
 
+## Recent Changes
+
+- BugFix: Removed Secrets SDK requirement when Imperative is a bundled dependency. [#2276](https://github.com/zowe/zowe-cli/issues/2276)
+
 ## `8.0.0`
 
 - MAJOR: v8.0.0 Release

diff --git a/packages/imperative/src/config/src/ConvertV1Profiles.ts b/packages/imperative/src/config/src/ConvertV1Profiles.ts
@@ -20,7 +20,7 @@ import { IConfig } from "./doc/IConfig";
 import { CredentialManagerFactory } from "../../security";
 import { IConvertV1ProfOpts, ConvertMsg, ConvertMsgFmt, IConvertV1ProfResult } from "./doc/IConvertV1Profiles";
 import { IImperativeOverrides } from "../../imperative/src/doc/IImperativeOverrides";
-import { keyring } from "@zowe/secrets-for-zowe-sdk";
+import type { keyring } from "@zowe/secrets-for-zowe-sdk";
 import { AppSettings } from "../../settings";
 import { ISettingsFile } from "../../settings/src/doc/ISettingsFile";
 import { ImperativeConfig } from "../../utilities";

diff --git a/packages/imperative/src/security/src/DefaultCredentialManager.ts b/packages/imperative/src/security/src/DefaultCredentialManager.ts
@@ -13,7 +13,7 @@ import { AbstractCredentialManager, SecureCredential } from "./abstract/Abstract
 import { ImperativeError } from "../../error";
 import { Logger } from "../../logger";
 
-import { keyring as keytar } from "@zowe/secrets-for-zowe-sdk"; // Used for typing purposes only
+import type { keyring as keytar } from "@zowe/secrets-for-zowe-sdk"; // Used for typing purposes only
 
 /**
  * Default Credential Manager is our implementation of the Imperative Credential Manager. This manager invokes methods